fixes and cleanup

vaadin · Oct 2, 2024 · 1dbb20f · 1dbb20f
1 parent 758542e
commit 1dbb20f
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 5 deletions.
diff --git a/packages/dashboard/src/vaadin-dashboard-layout.d.ts b/packages/dashboard/src/vaadin-dashboard-layout.d.ts
@@ -35,7 +35,7 @@ import { DashboardLayoutMixin } from './vaadin-dashboard-layout-mixin.js';
  * `--vaadin-dashboard-col-max-width` | maximum column width of the layout
  * `--vaadin-dashboard-row-min-height` | minimum row height of the layout
  * `--vaadin-dashboard-col-max-count` | maximum column count of the layout
- * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges
+ * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges. Must be in length units (0 is not allowed, 0px is)
  *
  * The following state attributes are available for styling:
  *

diff --git a/packages/dashboard/src/vaadin-dashboard-layout.js b/packages/dashboard/src/vaadin-dashboard-layout.js
@@ -38,7 +38,7 @@ import { DashboardLayoutMixin } from './vaadin-dashboard-layout-mixin.js';
  * `--vaadin-dashboard-col-max-width` | maximum column width of the layout
  * `--vaadin-dashboard-row-min-height` | minimum row height of the layout
  * `--vaadin-dashboard-col-max-count` | maximum column count of the layout
- * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges
+ * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges. Must be in length units (0 is not allowed, 0px is)
  *
  * The following state attributes are available for styling:
  *

diff --git a/packages/dashboard/src/vaadin-dashboard-styles.js b/packages/dashboard/src/vaadin-dashboard-styles.js
@@ -31,6 +31,7 @@ export const dashboardWidgetAndSectionStyles = css`
 
  header {
  display: flex;
+ overflow: hidden;
  }
 
  vaadin-button {

diff --git a/packages/dashboard/src/vaadin-dashboard-widget.js b/packages/dashboard/src/vaadin-dashboard-widget.js
@@ -127,6 +127,7 @@ class DashboardWidget extends DashboardItemMixin(
 
  #content {
  flex: 1;
+ overflow: hidden;
  }
 
  #resize-handle {

diff --git a/packages/dashboard/src/vaadin-dashboard.d.ts b/packages/dashboard/src/vaadin-dashboard.d.ts
@@ -196,7 +196,7 @@ export interface DashboardI18n {
  * `--vaadin-dashboard-col-max-width` | maximum column width of the dashboard
  * `--vaadin-dashboard-row-min-height` | minimum row height of the dashboard
  * `--vaadin-dashboard-col-max-count` | maximum column count of the dashboard
- * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges
+ * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges. Must be in length units (0 is not allowed, 0px is)
  *
  * The following state attributes are available for styling:
  *

diff --git a/packages/dashboard/src/vaadin-dashboard.js b/packages/dashboard/src/vaadin-dashboard.js
@@ -77,7 +77,7 @@ import { WidgetResizeController } from './widget-resize-controller.js';
  * `--vaadin-dashboard-col-max-width` | maximum column width of the dashboard
  * `--vaadin-dashboard-row-min-height` | minimum row height of the dashboard
  * `--vaadin-dashboard-col-max-count` | maximum column count of the dashboard
- * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges
+ * `--vaadin-dashboard-spacing` | spacing between child elements and space around its outer edges. Must be in length units (0 is not allowed, 0px is)
  *
  * The following state attributes are available for styling:
  *

diff --git a/packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js b/packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js
@@ -62,7 +62,6 @@ const dashboardWidgetAndSection = css`
  display: flex;
  align-items: center;
  padding: var(--lumo-space-s) var(--lumo-space-m);
- height: var(--lumo-size-m);
  gap: var(--lumo-space-s);
  }