fix: always define custom element class version getter #7813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an error with version listed as
undefined
when trying to re-define the same class with a different version:The issue is a regression from #6568 where I moved the version number from
static get version()
(always available) to be hardcoded in thedefineCustomElement
(only available for the first custom element definition).The fix is to always define a version getter, regardless of whether the custom element is already defined or not.
Type of change