test: update menu-bar visual tests to not capture full body #7841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
test/menu-bar-visual-tests
branch
from
e70d297
to
c95c434
Compare
|
|
Could web-test-runner's |
|
Visual tests are using SauceLabs launcher through |
sissbruecker
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When bumping browser version, document height might change which causes many visual tests to break.
In case of
vaadin-menu-barthere is no need to capturedocument.bodyso I changed to usediv.Updated
widthandheightto ensure there is enough space to display the opened sub-menu.Type of change
Note
Updated only Lumo visual tests for now as I'm going to bump Chrome version for Lumo first.