test: add date-time-picker editor to grid-pro integration test #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Sep 25, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
web-padawan
added a commit
that referenced
this pull request
Sep 25, 2024
#7865) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
vaadin-date-time-pickercolumn to grid-pro integration test with some TODOs to be fixed by #7858In particular, switching pickers by pressing Tab currently stops cell editing on
focusoutwhich is a bug.Before V22 it was working as
vaadin-date-time-pickerinheritedinternal-tabevent fromvaadin-custom-field.However, after we refactored it to not depend on
vaadin-custom-fieldusing it in grid-pro became broken.Also removed "first name" and "last name" columns as they aren't needed by this test and to make all columns fit.
Type of change