feat: dashboard lumo styles #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
commented
Oct 2, 2024
packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js
Outdated
Show resolved
Hide resolved
|
There seems to be an issue with dragging an unfocused item in Firefox with this change. I cannot reproduce it using the feature branch. |
|
FIxed, also fixed the following as discussed internally
|
tomivirkki
force-pushed
the
feat/dashboard-lumo-styles
branch
from
d14720b
to
f6c7065
Compare
ugur-vaadin
approved these changes
Oct 4, 2024
yuriy-fix
approved these changes
Oct 4, 2024
| aria-label="${this.__i18n.resizeGrowWidth}" | ||
| title="${this.__i18n.resizeGrowWidth}" | ||
| @click="${() => fireResize(this, 1, 0)}" | ||
| id="resize-grow-width" | ||
| ></button> | ||
| <button | ||
| part="resize-grow-width-button" |
There was a problem hiding this comment.
Nit: might consider expand instead of grow 🤔
There was a problem hiding this comment.
The terminology is the same that's used for the accessible names/i18n, originating from here. Let's discuss changing it separately.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First iteration of dashboard Lumo theme.
Visual tests are to be added separately once the component design is finalized.
Part of https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=75293217
Type of change
Feature