Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vaadin-dashboard component #7946

Merged
merged 67 commits into from
Oct 8, 2024
Merged

feat: vaadin-dashboard component #7946

merged 67 commits into from
Oct 8, 2024

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 7, 2024 •
edited
Loading

Description

This PR merges the dashboard package from feat/dashboard to main

Note: merge this PR with "Create a merge commit"

Type of change

Feature

tomivirkki and others added 30 commits August 14, 2024 13:56
@tomivirkki
feat: create dashboard package (#7647)
2134205
@tomivirkki
feat: add vaadin-dashboard-layout (#7653)
8864042
@tomivirkki
feat: add colspan support to dashboard (#7657)
e0a2f54
@tomivirkki
feat: add gap support to dashboard (#7660)
3c451c6
@tomivirkki
feat: make dashboard scrollable (#7662)
d0dc816
@tomivirkki
feat: add max column count support to dashboard (#7670)
19ccbe9
@tomivirkki
feat: add basic dashboard widget structure (#7679)
3443482
@tomivirkki
feat: add items and renderer to dashboard (#7680)
f7051b0
@tomivirkki
feat: add basic dashboard section structure (#7685)
581160f
@tomivirkki
feat: add sections support to vaadin-dashboard (#7692)
a8e267c
@tomivirkki
refactor: rename vaadin-dashboard-widget-wrapper (#7697)
b2cc698
@tomivirkki
Merge branch 'main' into feat/dashboard
6586681
@tomivirkki
feat: auto-update widget title level (#7740)
158e64d
@tomivirkki
refactor: move dashboard CSS grid inside shadow root (#7742)
12acd14
@tomivirkki
feat: add minimum row height to dashboard (#7754)
176a6cf
@tomivirkki
feat: support drag-reordering of dashboard items (#7738)
b5bc352
@tomivirkki
feat: support elements in dashboard items (#7761)
a590b1b
@tomivirkki
feat: dashboard widget rowspan (#7781)
a51684e
@tomivirkki
feat: drag-resizing of dashboard items (#7791)
b64f6b6
@tomivirkki
refactor: use hostDisconnected to cleanup touchmove listener
c617dcb
@tomivirkki
test: show a nicer error message in expectLayout
80d689a
@tomivirkki
chore: avoid flicker on the initial render
601141d
@tomivirkki
fix: do not throw on drag when dashboard has one widget (#7802)
886742d
@tomivirkki
feat: dashboard widget remove button (#7800)
af5c2b1
@tomivirkki
fix: support resizing widgets in rtl (#7803)
fd1db23
@tomivirkki
feat: keep widget focus on dashboard items change (#7804)
8c35746
@tomivirkki
docs: add dashboard to readme
9f35872
@tomivirkki
refactor: use attributes for widget/section state (#7807)
9426214
@tomivirkki
refactor: rename internal variables
21aeab8
@tomivirkki
refactor: make the controllers not extend EventTarget
4dc2ade
ugur-vaadin and others added 9 commits September 30, 2024 09:35
@ugur-vaadin
feat: add dashboard dense mode (#7881)
c801860 
* feat: add dense mode

* refactor: remove dense property from dashboard and layout

* fix: make dashboard layout extend layout mixin

* chore: add js suffix to import
@ugur-vaadin
refactor: rename dense to dense layout (#7884)
462a19f
@ugur-vaadin
refactor: rename header slot to header content (#7896)
d7dd0a4 
* refactor: rename header slot to header content

* chore: update dev pages to use header content slot
@tomivirkki
refactor: repurpose dashboard-gap as dashboard-spacing (#7897)
3bc42b4
@ugur-vaadin @web-padawan
docs: add dashboard jsdocs (#7891)
f992988 
* docs: add dashboard jsdocs

* docs: add attr annotations

* docs: remove defaults from custom properties

* Update packages/dashboard/src/vaadin-dashboard-layout.d.ts

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>

* docs: add backticks to property names

* docs: replace header and inner html with text content

* docs: rename gap property to spacing

* chore: fix typo

* docs: rename header to header content

---------

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@tomivirkki
chore: remove unnecessary material files
1242381
@ugur-vaadin
docs: update spacing related jsdocs (#7901)
c7c0f1d
@tomivirkki
feat: dashboard lumo styles (#7904)
182159b
@tomivirkki
Merge remote-tracking branch 'origin/main' into feat/dashboard
a3adf4c
web-padawan
web-padawan reviewed Oct 7, 2024
View reviewed changes
packages/dashboard/src/keyboard-controller.js Outdated Show resolved Hide resolved
packages/dashboard/src/vaadin-dashboard-button.js Outdated Show resolved Hide resolved
packages/dashboard/src/vaadin-dashboard-helpers.js Outdated Show resolved Hide resolved
packages/dashboard/src/vaadin-dashboard-section.js Outdated Show resolved Hide resolved
packages/dashboard/src/vaadin-dashboard-styles.js Show resolved Hide resolved
packages/dashboard/src/widget-reorder-controller.js Outdated Show resolved Hide resolved
packages/dashboard/src/widget-resize-controller.js Outdated Show resolved Hide resolved
packages/dashboard/src/widget-resize-controller.js Outdated Show resolved Hide resolved
packages/dashboard/src/keyboard-controller.js Outdated Show resolved Hide resolved
packages/dashboard/src/vaadin-dashboard.js Outdated Show resolved Hide resolved
sissbruecker
sissbruecker reviewed Oct 7, 2024
View reviewed changes
dev/dashboard.html Outdated Show resolved Hide resolved
sissbruecker
sissbruecker approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly did manual testing. Reported a few smaller issues, otherwise works fine 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
23 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

@ZheSun88 ZheSun88 removed the request for review from vursen October 8, 2024 08:40
@tomivirkki tomivirkki merged commit 73c9d6b into main Oct 8, 2024
9 checks passed
@tomivirkki tomivirkki deleted the feat/dashboard branch October 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan left review comments

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

@sissbruecker sissbruecker sissbruecker approved these changes

@ugur-vaadin ugur-vaadin ugur-vaadin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomivirkki @DiegoCardoso @sissbruecker @web-padawan @ugur-vaadin