Skip to content

Commit

Permalink
[chassis] update the T3 device type (sonic-net#8779)
Browse files Browse the repository at this point in the history
Summary:
Fixes sonic-net#8700

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 201911
 202012
[x ] 202205
Approach
What is the motivation for this PR?
The cable length is calculated based on the neighbor type and device type. In the T2 topology the uplink neighbor type in the minigraph is defined as CoreRouter. This causes the device to pick incorrect cable length for uplink neighbors.

Example
https://github.com/sonic-net/sonic-buildimage/blob/aa46167fdd09b5f973d6c39529715ad75a2a58ec/device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers_defaults_t2.j2#L3-L9

How did you do it?
This PR fixes the neighbor type of uplink neighbors to be set to RegionalHub or AZNGHub to match the values defined in the buffer_default_t2.j2
  • Loading branch information
arlakshm authored Jul 6, 2023
1 parent 2e27893 commit f1b6442
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion ansible/templates/minigraph_png.j2
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,11 @@
{% elif 'T2' in dev %}
{% set dev_type = 'SpineRouter' %}
{% elif 'T3' in dev %}
{% set dev_type = 'CoreRouter' %}
{% if loop.index|int % 2 %}
{% set dev_type = 'RegionalHub' %}
{% else %}
{% set dev_type = 'AZNGHub' %}
{% endif %}
{% elif 'T0' in dev %}
{% set dev_type = 'ToRRouter' %}
{% elif 'M1' in dev %}
Expand Down

0 comments on commit f1b6442

Please sign in to comment.