Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update links to point to published Discovery Recommendation #70

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

JKRhb
Copy link
Contributor

@JKRhb JKRhb commented Dec 14, 2023

Should resolve #61.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JKRhb as always. I noticed that you pointed to the latest published version. I think it is safer to point to the versioned document. What do you think?

@JKRhb
Copy link
Contributor Author

JKRhb commented Dec 18, 2023

Thank you @JKRhb as always. I noticed that you pointed to the latest published version. I think it is safer to point to the versioned document. What do you think?

Thank you, @relu91, that was a very good point! The PR should now be updated accordingly :)

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good to go from my side!

@hyperloris
Copy link
Member

Thank you @JKRhb for the new contribution. I looked at the PR status, and it's also a green light for me.

@hyperloris hyperloris merged commit 99bc2eb into vaimee:main Dec 18, 2023
3 checks passed
@JKRhb JKRhb deleted the update-docs branch December 18, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation link with the published Discovery Specification
3 participants