WIP - Async commands #144
WIP - Async commands #144
Conversation
… is async then the result of command will be ChannelResultAsync, otherwise ChannelResultSync
|
|
||
| // Handle response arguments to issued command | ||
| fn execute_message<M: ChannelMessageMode>(&mut self) { | ||
| let channel_result = M::handle(Box::leak(self.message.clone().into_boxed_str())); |
There was a problem hiding this comment.
This is unsafe, It should be avoided
There was a problem hiding this comment.
It's just workaround for testing...
| { | ||
| self.thread_pool.lock().unwrap().scope(|s| { | ||
| s.spawn(move |_| func()); | ||
| }); |
There was a problem hiding this comment.
scope is executing tasks within scoped thread pool, the thing is that this operation blocks the main thread. I need to rework that.
|
@valeriansaliou I've done some things and almost succeed. There is one thing that is still blocking asynchronous execution, but I have already plan how to solve it. Could you make a code review? |
|
Thanks a ton!! I’ll be reviewing this soon, had no chance so far as my week is unusually busy with Crisp. |
I could give your changes a quick look, and they look good to me. I'd say you can continue on this path! |
|
Great, I will! |
|
Keep me posted on your progress on this one, I have a bit more time for reviews :) |
|
Fine, I need to find some time |
|
There are conflicts to resolve, and probably some changes might be required due to the latest Rust async improvements. |
ref: #43
In progres...