-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TELCODOCS-1325: Create a snippet for tech preview #291
TELCODOCS-1325: Create a snippet for tech preview #291
Conversation
@danmacpherson: This pull request references TELCODOCS-1325 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit, rest looks good
/lgtm
modules/technology-preview.adoc
Outdated
{FeatureName} is a Technology Preview feature only. Technology Preview features | ||
are not supported with Red Hat production service level agreements (SLAs) and | ||
might not be functionally complete. Red Hat does not recommend using them | ||
in production. These features provide early access to upcoming product | ||
features, enabling customers to test functionality and provide feedback during | ||
the development process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hard line breaks. (Submitted openshift/openshift-docs#62618 to get this fixed for the OpenShift snippet too)
Copied this directly from the OpenShift docs repo: https://github.com/openshift/openshift-docs/blob/main/snippets/technology-preview.adoc Story: https://issues.redhat.com/browse/TELCODOCS-1325
30d6cbd
to
4608577
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: abhatt-rh, danmacpherson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Copied this directly from the OpenShift docs repo:
https://github.com/openshift/openshift-docs/blob/main/snippets/technology-preview.adoc
Story: https://issues.redhat.com/browse/TELCODOCS-1325