Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TELCODOCS-1325: Create a snippet for tech preview #291

Merged

Conversation

danmacpherson
Copy link
Collaborator

@danmacpherson danmacpherson self-assigned this Jul 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023

@danmacpherson: This pull request references TELCODOCS-1325 which is a valid jira issue.

In response to this:

Copied this directly from the OpenShift docs repo:

https://github.com/openshift/openshift-docs/blob/main/snippets/technology-preview.adoc

Story: https://issues.redhat.com/browse/TELCODOCS-1325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, rest looks good
/lgtm

Comment on lines 7 to 12
{FeatureName} is a Technology Preview feature only. Technology Preview features
are not supported with Red Hat production service level agreements (SLAs) and
might not be functionally complete. Red Hat does not recommend using them
in production. These features provide early access to upcoming product
features, enabling customers to test functionality and provide feedback during
the development process.
Copy link
Collaborator

@abhatt-rh abhatt-rh Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard line breaks. (Submitted openshift/openshift-docs#62618 to get this fixed for the OpenShift snippet too)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: abhatt-rh, danmacpherson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danmacpherson danmacpherson merged commit 9fb4eeb into validatedpatterns:main Jul 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants