Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-2000 documenting the AGOF 2 #477

Merged
merged 22 commits into from
Oct 15, 2024
Merged

TELCODOCS-2000 documenting the AGOF 2 #477

merged 22 commits into from
Oct 15, 2024

Conversation

kquinn1204
Copy link
Collaborator

@kquinn1204 kquinn1204 commented Sep 17, 2024 •
edited
Loading

@mbaldessari
Copy link
Contributor

This is an automated message:

You can preview this docs PR at http://477.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

@openshift-ci openshift-ci bot added the size/L label Sep 17, 2024
@openshift-ci openshift-ci bot added size/M and removed size/L labels Sep 23, 2024
@openshift-ci openshift-ci bot added size/L and removed size/M labels Sep 25, 2024
@openshift-ci openshift-ci bot added size/XL and removed size/L labels Sep 30, 2024
mhjacks
mhjacks reviewed Oct 2, 2024
View reviewed changes
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
@kquinn1204
Copy link
Collaborator Author

@danmacpherson @hbisht-RH-ccs please review thsi PR for VP AGOF framework

hbisht-RH-ccs
hbisht-RH-ccs reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@hbisht-RH-ccs hbisht-RH-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kquinn1204 I've added my review comments. Feel free to accept or reject the suggestions. Thanks!

content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
@mhjacks
Copy link
Contributor

mhjacks commented Oct 11, 2024

The docs (with respect to how the config is loaded) has been updated via validatedpatterns/agof#26. In order to generalize how controller configs are handled, there's a separation now between the project that is used for the GitOps pattern and the config that is loaded. (The config needs to specify the project).

@kquinn1204
Copy link
Collaborator Author

HI @mhjacks I have revised that direction as you OK with LGTM On this PR so it can make it into docs

mhjacks
mhjacks requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mhjacks mhjacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, these should be quick fixes, and most of them are my fault for missing the refs in the AGOF README

content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof.adoc Outdated Show resolved Hide resolved
content/learn/vp_agof_config_controller.adoc Outdated Show resolved Hide resolved
@kquinn1204
Copy link
Collaborator Author

@mhjacks is this revised version OK ?

@mhjacks
Copy link
Contributor

mhjacks commented Oct 15, 2024

LGTM! Thanks for all the work on this!

mhjacks
mhjacks approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mhjacks mhjacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm label Oct 15, 2024
@kquinn1204 kquinn1204 merged commit 9f0835c into validatedpatterns:main Oct 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbisht-RH-ccs hbisht-RH-ccs hbisht-RH-ccs left review comments

@danmacpherson danmacpherson danmacpherson left review comments

@mhjacks mhjacks mhjacks approved these changes

Assignees

@mhjacks mhjacks

Labels
lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kquinn1204 @mbaldessari @mhjacks @danmacpherson @hbisht-RH-ccs