Skip to content

Commit

Permalink
Make the registry explicit with the obsidiandynamics/kafdrop:latest i…
Browse files Browse the repository at this point in the history
…mage (#91)

Don't just assume that `obsidiandynamics/kafdrop:latest` always points
to docker.io automatically. Be explicit.

Tested with:

    podman pull docker.io/obsidiandynamics/kafdrop:latest
    Trying to pull docker.io/obsidiandynamics/kafdrop:latest...
    Getting image source signatures
    Copying blob 86fbbbe1ee3f [=>------------------------------------] 10.3MiB / 172.0MiB
    ...

The reason this is needed is that when we install certain operators from
an IIB (Image Index Bundle), we also need to whitelist which registries
a machine is allowed to connect to and making this explicit makes this
work in a more obvious manner.
  • Loading branch information
mbaldessari authored Aug 1, 2023
1 parent 80d44c6 commit 5c73bea
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion charts/all/kafdrop/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ kafka:
replicas: 3
deployment:
replicas: 1
image: "obsidiandynamics/kafdrop:latest"
image: "docker.io/obsidiandynamics/kafdrop:latest"
env:
- name: KAFKA_BROKERCONNECT
value: "xray-cluster-kafka-0.xray-cluster-kafka-brokers.xraylab-1.svc:9092"
Expand Down
2 changes: 1 addition & 1 deletion charts/all/kafka/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kafka:
replicas: 3
deployment:
replicas: 1
image: "obsidiandynamics/kafdrop:latest"
image: "docker.io/obsidiandynamics/kafdrop:latest"
env:
- name: KAFKA_BROKERCONNECT
value: "xray-cluster-kafka-0.xray-cluster-kafka-brokers.xraylab-1.svc:9092"
Expand Down
2 changes: 1 addition & 1 deletion tests/all-kafdrop-industrial-edge-factory.expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
spec:
containers:
- name: kafdrop
image: obsidiandynamics/kafdrop:latest
image: docker.io/obsidiandynamics/kafdrop:latest
ports:
- containerPort: 9000
env:
Expand Down
2 changes: 1 addition & 1 deletion tests/all-kafdrop-industrial-edge-hub.expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
spec:
containers:
- name: kafdrop
image: obsidiandynamics/kafdrop:latest
image: docker.io/obsidiandynamics/kafdrop:latest
ports:
- containerPort: 9000
env:
Expand Down
2 changes: 1 addition & 1 deletion tests/all-kafdrop-medical-diagnosis-hub.expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
spec:
containers:
- name: kafdrop
image: obsidiandynamics/kafdrop:latest
image: docker.io/obsidiandynamics/kafdrop:latest
ports:
- containerPort: 9000
env:
Expand Down
2 changes: 1 addition & 1 deletion tests/all-kafdrop-naked.expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
spec:
containers:
- name: kafdrop
image: obsidiandynamics/kafdrop:latest
image: docker.io/obsidiandynamics/kafdrop:latest
ports:
- containerPort: 9000
env:
Expand Down
2 changes: 1 addition & 1 deletion tests/all-kafdrop-normal.expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
spec:
containers:
- name: kafdrop
image: obsidiandynamics/kafdrop:latest
image: docker.io/obsidiandynamics/kafdrop:latest
ports:
- containerPort: 9000
env:
Expand Down

0 comments on commit 5c73bea

Please sign in to comment.