Fix secret parsing, when there is no secret in secret yaml file #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix the edge case when there is an empty list ([]) or no secret in the secret values file for a pattern, the validation and the parsing would fail the module. Now it only throws a warning for both validation and parsing.
mhjacks
requested changes
Oct 8, 2024
There was a problem hiding this comment.
I think we need to change the None test. Should we also have tests?
Also, we should change the version in galaxy.yml. In the narrowest possible view this is backwards incompatible, but I can't imagine anyone depends on this to throw these exceptions this way, and it would seem even odder to call this 2.0.0 for this
The check for "None" is better placed inside the get_secrets function, with this, get_secrets will always return a list, either empty list, or the list with the secrets from the yaml. Changed checks accordingly. Changed default get to be an empty list if the "secret" key is not present in the secret values file.
|
LGTM |
Added check for None type as well, in case the module is used witout from_yaml filter (like in unit tests)
|
Looks even better to me now with tests (LEBTMNWT). :) |
mhjacks
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the edge case when there is an empty list ([]) or no secret in the secret values file for a pattern, the validation and the parsing would fail the module. Now it only throws a warning for both validation and parsing.