Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla bug 1861068 - Make nsHTML5AttributeName constructors not allocate #90

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Oct 25, 2023

No description provided.

Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fourth name (l3/htmlLang) should not show up on the C++ side.

@emilio emilio force-pushed the attr-more-static branch 2 times, most recently from 0a4d03d to 271420b Compare October 25, 2023 16:06
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I'll merge after the Gecko change lands.)

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 26, 2023
…=hsivonen

This removes a bunch of allocations on startup.

Java changes: validator/htmlparser#90

Differential Revision: https://phabricator.services.mozilla.com/D191870
@hsivonen hsivonen merged commit 32c2256 into validator:master Oct 26, 2023
9 checks passed
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Oct 26, 2023
…=hsivonen

This removes a bunch of allocations on startup.

Java changes: validator/htmlparser#90

Differential Revision: https://phabricator.services.mozilla.com/D191870
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 30, 2023
…=hsivonen

This removes a bunch of allocations on startup.

Java changes: validator/htmlparser#90

Differential Revision: https://phabricator.services.mozilla.com/D191870

UltraBlame original commit: 985243cb1046dbaa1342236ec47d57dee8ba8475
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 30, 2023
…=hsivonen

This removes a bunch of allocations on startup.

Java changes: validator/htmlparser#90

Differential Revision: https://phabricator.services.mozilla.com/D191870

UltraBlame original commit: 985243cb1046dbaa1342236ec47d57dee8ba8475
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 30, 2023
…=hsivonen

This removes a bunch of allocations on startup.

Java changes: validator/htmlparser#90

Differential Revision: https://phabricator.services.mozilla.com/D191870

UltraBlame original commit: 985243cb1046dbaa1342236ec47d57dee8ba8475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants