-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mozilla bug 1861068 - Make nsHTML5AttributeName constructors not allocate #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsivonen
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fourth name (l3
/htmlLang
) should not show up on the C++ side.
translator-src/nu/validator/htmlparser/cpptranslate/CppVisitor.java
Outdated
Show resolved
Hide resolved
emilio
force-pushed
the
attr-more-static
branch
2 times, most recently
from
October 25, 2023 16:06
0a4d03d
to
271420b
Compare
emilio
force-pushed
the
attr-more-static
branch
from
October 25, 2023 16:09
271420b
to
a450abf
Compare
hsivonen
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(I'll merge after the Gecko change lands.)
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 26, 2023
…=hsivonen This removes a bunch of allocations on startup. Java changes: validator/htmlparser#90 Differential Revision: https://phabricator.services.mozilla.com/D191870
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 26, 2023
…=hsivonen This removes a bunch of allocations on startup. Java changes: validator/htmlparser#90 Differential Revision: https://phabricator.services.mozilla.com/D191870
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 30, 2023
…=hsivonen This removes a bunch of allocations on startup. Java changes: validator/htmlparser#90 Differential Revision: https://phabricator.services.mozilla.com/D191870 UltraBlame original commit: 985243cb1046dbaa1342236ec47d57dee8ba8475
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 30, 2023
…=hsivonen This removes a bunch of allocations on startup. Java changes: validator/htmlparser#90 Differential Revision: https://phabricator.services.mozilla.com/D191870 UltraBlame original commit: 985243cb1046dbaa1342236ec47d57dee8ba8475
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 30, 2023
…=hsivonen This removes a bunch of allocations on startup. Java changes: validator/htmlparser#90 Differential Revision: https://phabricator.services.mozilla.com/D191870 UltraBlame original commit: 985243cb1046dbaa1342236ec47d57dee8ba8475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.