Check ptr in cluster_slot_destroy

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
valkey-io · Oct 9, 2024 · 4d1fba6 · 4d1fba6
1 parent d6586c7
commit 4d1fba6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/cluster.c b/src/cluster.c
@@ -333,6 +333,8 @@ static int cluster_slot_ref_node(cluster_slot *slot, valkeyClusterNode *node) {
 }
 
 static void cluster_slot_destroy(cluster_slot *slot) {
+    if (slot == NULL)
+        return;
     slot->start = 0;
     slot->end = 0;
     slot->node = NULL;
@@ -846,9 +848,7 @@ static dict *parse_cluster_slots(valkeyClusterContext *cc, valkeyReply *reply) {
 
 error:
     dictRelease(nodes);
-    if (slot != NULL) {
-        cluster_slot_destroy(slot);
-    }
+    cluster_slot_destroy(slot);
     return NULL;
 }