Remove internal func __valkeyClusterGetReply()

src/valkeycluster.c

@@ -2112,21 +2112,6 @@ static int valkeyClusterGetReplyFromNode(valkeyClusterContext *cc,
     return VALKEY_OK;
 }
 
-static int __valkeyClusterGetReply(valkeyClusterContext *cc, int slot_num,
-                                   void **reply) {
-    valkeyClusterNode *node;
-
-    if (cc == NULL || slot_num < 0 || reply == NULL)
-        return VALKEY_ERR;
-
-    node = node_get_by_table(cc, (uint32_t)slot_num);
-    if (node == NULL) {
-        return VALKEY_ERR;
-    }
-
-    return valkeyClusterGetReplyFromNode(cc, node, reply);
-}
-
 /* Parses a MOVED or ASK error reply and returns the destination node. The slot
  * is returned by pointer, if provided. */
 static valkeyClusterNode *getNodeFromRedirectReply(valkeyClusterContext *cc,
@@ -3414,6 +3399,7 @@ int valkeyClusterGetReply(valkeyClusterContext *cc, void **reply) {
     listNode *list_command, *list_sub_command;
     int slot_num;
     void *sub_reply;
+    valkeyClusterNode *node;
 
     if (cc == NULL || reply == NULL)
         return VALKEY_ERR;
@@ -3445,7 +3431,9 @@ int valkeyClusterGetReply(valkeyClusterContext *cc, void **reply) {
     if (slot_num >= 0) {
         /* Command was sent via single slot */
         listDelNode(cc->requests, list_command);
-        return __valkeyClusterGetReply(cc, slot_num, reply);
+        if ((node = node_get_by_table(cc, (uint32_t)slot_num)) == NULL)
+            return VALKEY_ERR;
+        return valkeyClusterGetReplyFromNode(cc, node, reply);
 
     } else if (command->node_addr) {
         /* Command was sent to a single node */
@@ -3488,8 +3476,10 @@ int valkeyClusterGetReply(valkeyClusterContext *cc, void **reply) {
                                   "sub_command slot_num is less then zero");
             goto error;
         }
-
-        if (__valkeyClusterGetReply(cc, slot_num, &sub_reply) != VALKEY_OK) {
+        if ((node = node_get_by_table(cc, (uint32_t)slot_num)) == NULL) {
+            goto error;
+        }
+        if (valkeyClusterGetReplyFromNode(cc, node, &sub_reply) != VALKEY_OK) {
             goto error;
         }