Rename offensive defines and members in API #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use primary/replica instead of master/slave and use unknown instead of null. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
LGTM
When I saw "use UNKNOWN instead of NULL" in the PR description, I first thought it's about renaming the NULL pointers. (I though what!? Is NULL an offesive word?), but then I realized it's about the unknown role. So maybe formulate this in another way, for example use the full macro names instead of a bare NULL. :)
mkmkme
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
VALKEY_ROLE_PRIMARYinstead ofVALKEY_ROLE_MASTER.Use
VALKEY_ROLE_REPLICAinstead ofVALKEY_ROLE_SLAVE.Use
VALKEY_ROLE_UNKNOWNinstead ofVALKEY_ROLE_NULL.valkeyClusterNodememberslavestoreplicas.