Add Valkey8 support #2102
Closed
Add Valkey8 support #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
force-pushed
the
valkey-8
branch
3 times, most recently
from
0f57133
to
9660c60
Compare
shohamazon
force-pushed
the
valkey-8
branch
4 times, most recently
from
30943b8
to
1713afa
Compare
shohamazon
force-pushed
the
valkey-8
branch
17 times, most recently
from
b834291
to
453160a
Compare
shohamazon
added
python
shohamazon
force-pushed
the
valkey-8
branch
7 times, most recently
from
7552f1d
to
9e56a07
Compare
Signed-off-by: Shoham Elias <shohame@amazon.com>
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
barshaul
reviewed
Aug 20, 2024
| @@ -62,6 +62,7 @@ runs: | |||
| echo 'export PATH=/usr/local/bin:$PATH' >>~/.bash_profile | |||
|
|
|||
| - name: Verify Valkey installation and symlinks | |||
| if: ${{ !contains(inputs.engine-version, '-rc1') }} | |||
There was a problem hiding this comment.
it's too specific. change to
Suggested change
| if: ${{ !contains(inputs.engine-version, '-rc1') }} | |
| if: ${{ !contains(inputs.engine-version, '-rc') }} |
barshaul
reviewed
Aug 20, 2024
barshaul
reviewed
Aug 20, 2024
barshaul
reviewed
Aug 20, 2024
| .toLowerCase() | ||
| .contains("can't write against a read only replica")); | ||
| if (SERVER_VERSION.isGreaterThanOrEqualTo("7.9.0")) { | ||
| assertEquals(OK, clusterClient.flushall(route).get()); |
There was a problem hiding this comment.
since valkey 8.0.8 flushall can run on replicas
barshaul
reviewed
Aug 20, 2024
Comment on lines
+415
to
419
| if not await check_if_server_version_lt(glide_client, "7.9.0"): | ||
| cluster_mode = parse_info_response(info_res)["server_mode"] | ||
| else: | ||
| cluster_mode = parse_info_response(info_res)["redis_mode"] | ||
| expected_cluster_mode = isinstance(glide_client, GlideClusterClient) |
barshaul
reviewed
Aug 20, 2024
Comment on lines
+846
to
+851
| assert "WATCH inside MULTI is not allowed" in str( | ||
| e | ||
| ) # TODO : add an assert on EXEC ABORT | ||
|
|
||
| else: | ||
| assert "Command not allowed inside a transaction" in str( |
There was a problem hiding this comment.
we can leave with "not allowed", remove the whole string message
barshaul
reviewed
Aug 20, 2024
| @@ -79,6 +79,9 @@ def get_random_string(length): | |||
| async def check_if_server_version_lt(client: TGlideClient, min_version: str) -> bool: | |||
| # TODO: change it to pytest fixture after we'll implement a sync client | |||
| info_str = await client.info([InfoSection.SERVER]) | |||
| valkey_version = parse_info_response(info_str).get("valkey_version") | |||
There was a problem hiding this comment.
valkey_version = parse_info_response(info_str).get("valkey_version")
server_version = valkey_version if valkey_version is not None else parse_info_response(info_str).get("redis_version")
barshaul
reviewed
Aug 20, 2024
| if (error) { | ||
| reject(error); | ||
| } else { | ||
| resolve(stdout.split("v=")[1].split(" ")[0]); |
barshaul
reviewed
Aug 20, 2024
| return cmd_args | ||
|
|
||
| # Try starting valkey-server first | ||
| server_name = "valkey-server" |
There was a problem hiding this comment.
put it in a dedicate function to check which server to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Added new command CLUSTER SLOT-STATS in each of the wrappers for CLUSTER mode only. PR #351implies a single slot.