Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: fix BITPOS #2227

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Node: fix BITPOS #2227

wants to merge 14 commits into from

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Sep 4, 2024

@cyip10 cyip10 marked this pull request as ready for review September 6, 2024 16:22
@cyip10 cyip10 requested a review from a team as a code owner September 6, 2024 16:22
acarbonetto
acarbonetto reviewed Sep 6, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Sep 6, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Sep 6, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
shohamazon
shohamazon previously requested changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for #2248 to be merged first

@Yury-Fridlyand Yury-Fridlyand linked an issue Sep 23, 2024 that may be closed by this pull request
Fix bitpos implementation for python and node #2343
Open
@asafpamzn asafpamzn added this to the 1.2 milestone Sep 30, 2024
@avifenesh avifenesh added bug Something isn't working and removed Valkey-8 labels Nov 21, 2024
@yipin-chen yipin-chen removed this from the 1.2 milestone Dec 2, 2024
cyip10 and others added 12 commits December 2, 2024 16:22
@cyip10 @jamesx-improving
implement node bitcount change
5c2555e 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @jamesx-improving
added in examples in base client
bdf169e 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @jamesx-improving
fix lint errors
ef7d8cc 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @jamesx-improving
fix linter issue
2d7b884 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @acarbonetto @jamesx-improving
fix spacing
6cb8177 
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Chloe Yip <168601573+cyip10@users.noreply.github.com>
@cyip10 @jamesx-improving
add function
357b376 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @jamesx-improving
fix lint errors
7efe372 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @jamesx-improving
fix createbitpos
5f4d3c6 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 @jamesx-improving
add changelog
22b2c74 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@Yury-Fridlyand @jamesx-improving
rebase
d83ccd6 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand @jamesx-improving
rebase
8a58d08 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand @jamesx-improving
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
bab0c11
@jamesx-improving
make 'start' required for BitOffsetOptions
c5bef0c 
Signed-off-by: James Xin <james.xin@improving.com>
@jamesx-improving
post rebase clean up
687b72f 
Signed-off-by: James Xin <james.xin@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesx-improving jamesx-improving jamesx-improving left review comments

@acarbonetto acarbonetto acarbonetto left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@yipin-chen yipin-chen yipin-chen approved these changes

@shohamazon shohamazon shohamazon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bitpos implementation for python and node
9 participants
@cyip10 @Yury-Fridlyand @acarbonetto @shohamazon @jamesx-improving @yipin-chen @avifenesh @asafpamzn @ikolomi