Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: fix pubsub IT #2317

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Sep 18, 2024

Required by #2296
Removing standalone client from a test which checks numsub and shardnumsub together, because shard commands available on cluster only. Those commands are checked in other tests.

fixes: #2327

@Yury-Fridlyand Yury-Fridlyand added Release blocker Can't release without. node Node.js wrapper testing Everything about testing Valkey-8 labels Sep 18, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 18, 2024 17:36
@ikolomi
Copy link
Collaborator

ikolomi commented Sep 19, 2024

@Yury-Fridlyand did you make sure this does not happen in other cluster-only tests?

@ikolomi ikolomi merged commit 1c3aa0d into valkey-io:release-1.1 Sep 19, 2024
9 checks passed
@acarbonetto acarbonetto deleted the node/yuryf-fix-pubsub-IT-8 branch September 19, 2024 17:00
@Yury-Fridlyand
Copy link
Collaborator Author

I run all pubsub IT on valkey 8 with this fix on another branch.

shohamazon pushed a commit to shohamazon/glide-for-redis that referenced this pull request Sep 23, 2024
…luster mode enabled flag (valkey-io#2317)

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper Release blocker Can't release without. testing Everything about testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants