Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BITCOUNT 'end' as optional like BITPOS #118

Merged
merged 12 commits into from
May 28, 2024
Merged

Change BITCOUNT 'end' as optional like BITPOS #118

merged 12 commits into from
May 28, 2024

Commits on Apr 2, 2024

  1. Fix to allow end as optional when using bitcount 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a6f4296 View commit details
    Browse the repository at this point in the history

  2. Fix hint for bitcount 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5b067d3 View commit details
    Browse the repository at this point in the history

  3. Add test in case for only using start in bitcount 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8e813f3 View commit details
    Browse the repository at this point in the history

  4. Remove unreachable code in BITCOUNT and BITPOS 

    in case of end is not declared, BYTE|BIT cannot be used, so variable 'isbit' is always 0

Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    64008bb View commit details
    Browse the repository at this point in the history

  5. Move line end = totlen - 1, after totlen declared 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    fb2e403 View commit details
    Browse the repository at this point in the history

  6. Add commands.def after build 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c758112 View commit details
    Browse the repository at this point in the history

  7. Add history for this fix 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    fc369bb View commit details
    Browse the repository at this point in the history

  8. Add commands.def after build 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d5f0da6 View commit details
    Browse the repository at this point in the history

  9. Update tests/unit/bitops.tcl 

    Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen @madolson
    LiiNen and madolson committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    729ec8b View commit details
    Browse the repository at this point in the history

  10. Fix test code : allowing bitcount without end now 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c0dd4ee View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Add test cases; larger value, negative larger value 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    843c84a View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'unstable' into bitcount-end-as-optional 

    Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
    @LiiNen
    LiiNen committed May 27, 2024
    Configuration menu
    Copy the full SHA
    153625c View commit details
    Browse the repository at this point in the history