Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes external server tests and change other references. #14

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

roshkhatri
Copy link
Member

Fixes external server tests and change other references.

Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes LGTM but I think @madolson should have a look and the final say.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we'll have to change all occurrences of placeholderkv again once we have a name for the project. Depending on how long that takes, we could wait for that before merging this.

@madolson
Copy link
Member

@zuiderkwast eh, there are some non-overlapping changes here as well (like the flags changes). We'll have to do a lot of scrubbing, doing a find and replace on placeholderkv is much faster than redis.

.github/workflows/daily.yml Show resolved Hide resolved
@zuiderkwast zuiderkwast merged commit 340ab6d into valkey-io:unstable Mar 25, 2024
13 checks passed
@PingXie PingXie added the rebranding Valkey is not Redis label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebranding Valkey is not Redis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants