Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for compiling with mimalloc #363

Open
wants to merge 29 commits into
base: unstable
Choose a base branch
from
Open

Add support for compiling with mimalloc #363

wants to merge 29 commits into from

Commits on Apr 26, 2024

  1. Rename remaining test procedures (valkey-io#355) 

    Renamed below procedures and variables (missed in valkey-io#287) as follows.

redis_cluster             ->     valkey_cluster
redis1                    ->     valkey1
redis2                    ->     valkey2
get_redis_dir             ->     get_valkey_dir
test_redis_cli_rdb_dump   ->     test_valkey_cli_rdb_dump
test_redis_cli_repl       ->     test_valkey_cli_repl
redis-cli                 ->     valkey-cli
redis_reset_state         ->     valkey_reset_state
redisHandle               ->     valkeyHandle
redis_safe_read           ->     valkey_safe_read
redis_safe_gets           ->     valkey_safe_gets
redis_write               ->     valkey_write
redis_read_reply          ->     valkey_read_reply
redis_readable            ->     valkey_readable
redis_readnl              ->     valkey_readnl
redis_writenl             ->     valkey_writenl
redis_read_map            ->     valkey_read_map
redis_read_line           ->     valkey_read_line
redis_read_null           ->     valkey_read_null
redis_read_bool           ->     valkey_read_bool
redis_read_double         ->     valkey_read_double
redis_read_verbatim_str   ->     valkey_read_verbatim_str
redis_call_callback       ->     valkey_call_callback

---------

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>

Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @Shivshankar-Reddy
    Shivshankar-Reddy authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8f202d2 View commit details
    Browse the repository at this point in the history

  2. Add support for compiling with mimalloc 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4bdc923 View commit details
    Browse the repository at this point in the history

  3. fix 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c5d5199 View commit details
    Browse the repository at this point in the history

  4. Add support to use system libraries 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0d7c60a View commit details
    Browse the repository at this point in the history

  5. Rename redis.tcl to valkey.tcl (valkey-io#283) 

    Includes some more changes e.g. the README under tests and some script under utils.

Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @hwware
    hwware authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    743d978 View commit details
    Browse the repository at this point in the history

  6. Update COPYING to Valkey (valkey-io#32) 

    Add License Copyright description for Valkey contributors in COPYING

---------

Signed-off-by: PatrickJS <github@patrickjs.com>
Signed-off-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>

Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @PatrickJS
    PatrickJS authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2778f3b View commit details
    Browse the repository at this point in the history

  7. Update redis* to valkey* in syscheck.c (valkey-io#365) 

    Fixes valkey-io#352

Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @hwware
    hwware authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9fc71a3 View commit details
    Browse the repository at this point in the history

  8. Update redis* to valkey* in server.c and module.c (valkey-io#367) 

    it's a supplementary modification from valkey-io#352.

Signed-off-by: artikell <739609084@qq.com>
Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @artikell
    artikell authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    08684da View commit details
    Browse the repository at this point in the history

  9. Rename redis to valkey in test suite logs and test names. (valkey-io#366 

    )

This PR covers below cases.
1. test suite's prints(i.e., puts statement logs).
2. Links refering to redis issues.
3. test names contains redis.

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @Shivshankar-Reddy
    Shivshankar-Reddy authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f144dc0 View commit details
    Browse the repository at this point in the history

  10. Detect accept4() on specific versions of various platforms (valkey-io… 

    …#294)

This PR has mainly done three things:

1. Enable `accept4()` on DragonFlyBSD
2. Fix the failures of determining the presence of `accept4()` due to
   the missing <sys/param.h> on two OSs: NetBSD, OpenBSD
3. Drop the support of FreeBSD < 10.0 for `valkey`

### References
- [param.h in
DragonFlyBSD](https://github.com/DragonFlyBSD/DragonFlyBSD/blob/7485684fa5c3fadb6c7a1da0d8bb6ea5da4e0f2f/sys/sys/param.h#L129-L257)
- [param.h in
FreeBSD](https://github.com/freebsd/freebsd-src/blob/main/sys/sys/param.h#L46-L76)
- [param.h in
NetBSD](https://github.com/NetBSD/src/blob/b5f8d2f930b7ef226d4dc1b4f7017e998c0e5cde/sys/sys/param.h#L53-L70)
- [param.h in
OpenBSD](https://github.com/openbsd/src/blob/d9c286e032a7cee9baaecdd54eb0d43f658ae696/sys/sys/param.h#L40-L45)

---------

Signed-off-by: Andy Pan <i@andypan.me>

Signed-off-by: Sher Sun <sher.sun@huawei.com>
    @panjf2000
    panjf2000 authored and Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    345e7a6 View commit details
    Browse the repository at this point in the history

  11. Remove the option for vendored mimalloc 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9f93823 View commit details
    Browse the repository at this point in the history

  12. remove mimalloc submodule 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c4b890a View commit details
    Browse the repository at this point in the history

  13. Merge branch 'valkey-io:unstable' into mimalloc-support

    @WM0323
    WM0323 authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1f1ca13 View commit details
    Browse the repository at this point in the history

  14. remove changes in the deps/Makefile 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4a39d8c View commit details
    Browse the repository at this point in the history

  15. remove USE_SYSTEM_MIMALLOC option 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    658aec3 View commit details
    Browse the repository at this point in the history

  16. Explicitly override malloc/free etc when using mimalloc 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f16f92f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. update the README.md with mimalloc install instructions and zmalloc.h 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    32d07dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'valkey-io:unstable' into mimalloc-support

    @WM0323
    WM0323 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fcc724b View commit details
    Browse the repository at this point in the history

  3. remove unused expansion 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1219f1c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'mimalloc-support' of https://github.com/WM0323/valkey i… 

    …nto mimalloc-support
    Sher Sun committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0438848 View commit details
    Browse the repository at this point in the history

  5. add defrag_supported field to INFO command 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    65ef92f View commit details
    Browse the repository at this point in the history

  6. fix 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    371641d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. remove defrag_supported macro 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b1431fa View commit details
    Browse the repository at this point in the history

  2. fix 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2f00910 View commit details
    Browse the repository at this point in the history

  3. fix2 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c9c3733 View commit details
    Browse the repository at this point in the history

  4. fix 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a594b55 View commit details
    Browse the repository at this point in the history

  5. fix3 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2466cb4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. add tcl test for defrag_supported 

    Signed-off-by: Sher Sun <sher.sun@huawei.com>
    Sher Sun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1854578 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'valkey-io:unstable' into mimalloc-support

    @WM0323
    WM0323 authored May 2, 2024
    Configuration menu
    Copy the full SHA
    e391645 View commit details
    Browse the repository at this point in the history