Skip to content

Commit

Permalink
Merge branch 'development' into feature/fr-ca-integration
Browse files Browse the repository at this point in the history
  • Loading branch information
lexasq authored Jul 15, 2024
2 parents 3c95747 + 7c18759 commit 60c6f4d
Show file tree
Hide file tree
Showing 33 changed files with 54 additions and 34 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "18.0.0"
"version": "18.0.2"
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,22 @@ <h2 id="installation">
<a class="anchor-link" routerLink="." fragment="installation">#</a>
</h2>
<h4>Angular CLI way</h4>
<p>Make sure that your app uses modular approach and you have app.module.ts set as your starting point before you proceed</p>
<pre class="prettyprint lang-js prettyprinted">
<span class="kwd">import</span><span class="pln"> </span><span class="pun">{{'{'}}</span><span class="kwd"> platformBrowser </span><span
class="pun">{{'}'}}</span><span class="pln"> from </span><span class="str">'&#64;angular/platform-browser'</span><span
class="pun">;</span>
<span class="kwd">import</span><span class="pln"> </span><span class="pun">{{'{'}}</span><span class="kwd"> AppModule </span><span
class="pun">{{'}'}}</span><span class="pln"> from </span><span class="str">'./app.module'</span><span
class="pun">;</span>
<span class="pln">&nbsp;</span>
<span class="pun">platformBrowser().bootstrapModule(AppModule).catch((err) => console.error(err));</span>
</pre>
<!-- // main.ts-->
<!-- import { platformBrowser } from '&#64;angular/platform-browser';-->
<!-- import { AppModule } from './app.module';-->

<!-- platformBrowser().bootstrapModule(AppModule).catch((err) => console.error(err));-->
<p>Use the Angular CLI ng add command for updating your Angular project.</p>
<pre class="prettyprint lang-bash prettyprinted"><span class="pln">ng add ngx-bootstrap</span></pre>

Expand Down Expand Up @@ -233,7 +249,7 @@ <h2 id="compatibility">
</thead>
<tbody>
<tr>
<th>13.x.x</th>
<th>18.x.x</th>
<th>18.x.x</th>
<th>5.x.x or 4.x.x</th>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap-base",
"version": "18.0.0",
"version": "18.0.2",
"license": "MIT",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"schematics": "./schematics/src/collection.json",
Expand Down
2 changes: 1 addition & 1 deletion src/accordion/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/accordion",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/alert/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/alert",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/buttons/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/buttons",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/carousel/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/carousel",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/chronos/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/chronos",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/collapse/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/collapse",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/component-loader/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/component-loader",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/datepicker/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/datepicker",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/dropdown/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/dropdown",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/focus-trap/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/focus-trap",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/locale/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/locale",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/mini-ngrx/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/mini-ngrx",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/modal/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/modal",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/pagination/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/pagination",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/popover/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/popover",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/positioning/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/positioning",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/progressbar/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/progressbar",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/rating/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/rating",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/root/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap",
"version": "18.0.0",
"version": "18.0.2",
"description": "Angular Bootstrap",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion src/schematics/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "schematics",
"version": "18.0.0",
"version": "18.0.2",
"schematics": "./collection.json",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
Expand Down
2 changes: 1 addition & 1 deletion src/schematics/src/utils/current_dependency_versions.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"NGX_BOOTSTRAP_VERSION": "18.0.0",
"NGX_BOOTSTRAP_VERSION": "18.0.2",
"BOOTSTRAP_VERSION": "^5.2.3"
}
4 changes: 4 additions & 0 deletions src/schematics/src/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ export function addModuleImportToRootModule(
if (!moduleSource) {
throw new SchematicsException(`Module not found: ${modulePath}`);
}
if (modulePath.includes('component')) {
throw new SchematicsException(`ngx-bootstrap doesn't support moduleless approach if we couldn't find
your starting *.module.ts learn more here https://valor-software.com/ngx-bootstrap/#/documentation#installation`);
}

const changes: Change[] = addImportToModule(moduleSource, modulePath, moduleName, src);
const recorder = host.beginUpdate(modulePath);
Expand Down
4 changes: 2 additions & 2 deletions src/schematics/src/utils/project-main-file.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import { workspaces } from '@angular-devkit/core';
/** Looks for the main TypeScript file in the given project and returns its path. */
export function getProjectMainFile(project: workspaces.ProjectDefinition): string {
const buildOptions = getProjectTargetOptions(project, 'build');
if (!buildOptions.main) {
if (!buildOptions.main && !buildOptions.browser) {
throw new SchematicsException(`Could not find the project main file inside of the ` +
`workspace config (${project.sourceRoot})`);
}

return buildOptions.main.toString();
return buildOptions.main?.toString() ?? buildOptions.browser.toString();
}
2 changes: 1 addition & 1 deletion src/sortable/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/sortable",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/tabs/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/tabs",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/timepicker/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/timepicker",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/tooltip/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/tooltip",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/typeahead/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/typeahead",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion src/utils/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-bootstrap/utils",
"version": "18.0.0",
"version": "18.0.2",
"author": "Dmitriy Shekhovtsov <valorkin@gmail.com>",
"license": "MIT"
}

0 comments on commit 60c6f4d

Please sign in to comment.