-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix setter var active #6435
base: development
Are you sure you want to change the base?
fix setter var active #6435
Conversation
Error in commit ceccdca
Codecov Report
@@ Coverage Diff @@
## development #6435 +/- ##
===============================================
+ Coverage 75.89% 75.93% +0.03%
===============================================
Files 315 315
Lines 10642 10640 -2
Branches 2935 2935
===============================================
+ Hits 8077 8079 +2
+ Misses 2564 2560 -4
Partials 1 1
Continue to review full report at Codecov.
|
Hy,
This PR fix a problem with this commit ceccdcac1de4316cc33a1067d604a6470c0245ba in file typeahead.directive.ts
In this commit, a function
setActive
is used to modify variable active, but an existing setter exist in the class.I delete the function
setActive
and replace the set of varactive
with the setter.It's possible to add this fix to the version 7. Because the accessibility of typeahead without the fix is bad.
Thanks.