-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore : Upgrade Angular 18 #6653
Chore : Upgrade Angular 18 #6653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@valorkin can you assign a reviewer please |
How about merging this? Would like to get an angular 18 compatible version of ngx-bootstrap :) |
i'm not authorized to merge |
LGTM |
@valorkin can you also release the new version on npm? 🙏 |
is there a time frame on when this fix is likely to get published? |
HI i cant get version 13.0 from npm. Is there anything wrong? |
hasn't been released yet |
Oh! crap I though it was released because under README Compatibility list it says version 13.x. |
waiting for npm release thx for your work ! |
Anything that can be done to prepare/help with releasing? |
Same here! Let us know if we can help in any way :) |
New to "open source". Is this the norm for the speed of how things move through the process for what looks to be a very popular piece of code with over 286K downloads a week? |
ping @valorkin |
Looks like version 13 is not published on npm. |
no, unfortunately its not published yet. i've asked @valorkin on linked in too if there is something to help with. unfortunately no answer yet |
it s published as version 18.0.0 |
Issues
#6652
Description
updated @nx/* and @angular/* family to version 18
updated via migrations
regenerated package-lock.json
updated README.md, mentioning that next major version will require/support Angular 18
fixed eslint issues
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.