Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore : Upgrade Angular 18 #6653

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

MatthiasHuygelen
Copy link
Contributor

@MatthiasHuygelen MatthiasHuygelen commented May 30, 2024

Issues

#6652

Description

updated @nx/* and @angular/* family to version 18

updated via migrations

regenerated package-lock.json

updated README.md, mentioning that next major version will require/support Angular 18

fixed eslint issues

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@MatthiasHuygelen MatthiasHuygelen changed the title Upgrade ng 18 Chore : Upgrade ng 18 May 31, 2024
@MatthiasHuygelen MatthiasHuygelen changed the title Chore : Upgrade ng 18 Chore : Upgrade Angular 18 May 31, 2024
Copy link

@PTAHume PTAHume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MatthiasHuygelen
Copy link
Contributor Author

@valorkin can you assign a reviewer please

@jonthe101
Copy link

How about merging this? Would like to get an angular 18 compatible version of ngx-bootstrap :)

@MatthiasHuygelen
Copy link
Contributor Author

How about merging this? Would like to get an angular 18 compatible version of ngx-bootstrap :)

i'm not authorized to merge

@valorkin
Copy link
Member

LGTM

@valorkin valorkin merged commit 322af2b into valor-software:development Jun 17, 2024
10 checks passed
@MatthiasHuygelen MatthiasHuygelen deleted the upgrade-ng-18 branch June 17, 2024 09:10
@lukaVarga
Copy link

@valorkin can you also release the new version on npm? 🙏

@MilesHeise
Copy link

is there a time frame on when this fix is likely to get published?

@Guling85
Copy link

HI i cant get version 13.0 from npm. Is there anything wrong?

@MatthiasHuygelen
Copy link
Contributor Author

HI i cant get version 13.0 from npm. Is there anything wrong?

hasn't been released yet

@Guling85
Copy link

HI i cant get version 13.0 from npm. Is there anything wrong?

hasn't been released yet

Oh! crap I though it was released because under README Compatibility list it says version 13.x.
I need to downgrade my project :). Is there any ETA? for this Thanks

@msitruk
Copy link

msitruk commented Jun 19, 2024

waiting for npm release thx for your work !

@skatterwe
Copy link

Anything that can be done to prepare/help with releasing?

@kees-wiegel-visma
Copy link

HI i cant get version 13.0 from npm. Is there anything wrong?

hasn't been released yet

Oh! crap I though it was released because under README Compatibility list it says version 13.x. I need to downgrade my project :). Is there any ETA? for this Thanks

Same here! Let us know if we can help in any way :)

@tasdpp
Copy link

tasdpp commented Jun 27, 2024

New to "open source". Is this the norm for the speed of how things move through the process for what looks to be a very popular piece of code with over 286K downloads a week?

@slubowsky
Copy link

ping @valorkin

@hamirilb
Copy link

Looks like version 13 is not published on npm.

@skatterwe
Copy link

skatterwe commented Jun 28, 2024

no, unfortunately its not published yet. i've asked @valorkin on linked in too if there is something to help with. unfortunately no answer yet

@toanho-dev
Copy link

toanho-dev commented Jul 2, 2024

it s published as version 18.0.0
https://www.npmjs.com/package/ngx-bootstrap/v/18.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.