Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adaptive-date): fix adaptive date positioning #6717

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

fix(adaptive-date): fix adaptive date positioning #6717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12195a6
fix(adaptive-date): fix adaptive date positioning
lexasq Dec 19, 2024
20936bb
fix(adaptive-date): fix adaptive date positioning
lexasq Dec 19, 2024
403c763
fix(playwright): bring ubuntu version to 22 to avoid installation errors
lexasq Dec 20, 2024
162b1a1
fix(playwright): bring ubuntu version to 22 to avoid installation errors
lexasq Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/on-push-or-pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ env:
jobs:
# one run
one_run:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0
Expand All @@ -35,7 +35,7 @@ jobs:

# install dependencies
install:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: one_run
steps:
- uses: actions/checkout@v3
Expand All @@ -50,7 +50,7 @@ jobs:
# build ngx-bootstrap
build:
needs: install
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v3
Expand All @@ -71,7 +71,7 @@ jobs:

# run unit tests
unit_tests_with_coverage:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build
steps:
- uses: actions/checkout@v3
Expand All @@ -90,7 +90,7 @@ jobs:

# run linting
linting:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: install
steps:
- uses: actions/checkout@v3
Expand All @@ -103,7 +103,7 @@ jobs:

# firebase deploy preview
firebase_preview:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build
outputs:
output_url: ${{ steps.firebase_hosting_preview.outputs.details_url }}
Expand All @@ -126,7 +126,7 @@ jobs:
# run playwright
e2e_smoke:
name: e2e smoke (${{ matrix.shard }}/${{ strategy.job-total }})
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: [install, build, firebase_preview]

strategy:
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:

e2e_full:
name: e2e full
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: [e2e_smoke]

strategy:
Expand Down
2 changes: 1 addition & 1 deletion src/datepicker/themes/bs/bs-datepicker-container.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { NgIf, NgClass, NgSwitch, NgSwitchCase, NgFor, AsyncPipe } from '@angula

@Component({
selector: 'bs-datepicker-container',
providers: [BsDatepickerStore, BsDatepickerEffects, BsDatepickerActions, PositioningService],
providers: [BsDatepickerStore, BsDatepickerEffects, BsDatepickerActions],
templateUrl: './bs-datepicker-view.html',
host: {
class: 'bottom',
Expand Down
Loading