internal/Painter: remove configurable edge FBA, use fallback alloc #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the configurable FBA for the edge cache, moving it to a fallback allocator instead, with the FBA being a much smaller size, so that we respect the stack a lot more. The FBA should be enough for 64 edges worst-case scenario each edge is 4 bytes and may be duplicated in the final edge set, so 64*4*2 = 512 bytes. Note that not all edges make it into the final edge set (e.g., during non-zero fill), hence why we say worst-case. This can and will be optimized eventually to allow for more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the configurable FBA for the edge cache, moving it to a fallback allocator instead, with the FBA being a much smaller size, so that we respect the stack a lot more.
The FBA should be enough for 64 edges worst-case scenario each edge is 4 bytes and may be duplicated in the final edge set, so 6442 = 512 bytes. Note that not all edges make it into the final edge set (e.g., during non-zero fill), hence why we say worst-case. This can and will be optimized eventually to allow for more.