Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage improvements in SQLKit, SQLiteNIO, and SQLiteKit #90

Merged
merged 11 commits into from
May 15, 2024
Merged

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 14, 2024

These changes are now available in 4.7.0

Several improvements:

  • Swift minimum version is now 5.8, minimum dependency versions updated
  • Sendable and ExistentialAny correctness
  • README and docs cleanup, updated CI
  • Added support for custom JSON encoders and decoders
  • Added working support for setting the query logging level
  • Most operations are now routed through SQLiteKit rather than duplicating code, making behavior more consistent (and very slightly faster)
  • The new extended SQLite errors are now supported correctly (DatabaseError.isConstraintFailure works again).
  • The maxConnectionsPerEventLoop setting is now ignored, as increasing it beyond 1 increases thread contention with no additional parallelism.

@gwynne gwynne added bug Something isn't working enhancement New feature or request semver-minor Contains new APIs labels May 14, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy May 14, 2024 05:44
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 78.28947% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 82.54%. Comparing base (d76674f) to head (7107315).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   86.42%   82.54%   -3.88%     
==========================================
  Files           7        7              
  Lines         221      212       -9     
==========================================
- Hits          191      175      -16     
- Misses         30       37       +7     
Files Coverage Δ
Sources/FluentSQLiteDriver/Exports.swift 100.00% <100.00%> (ø)
...s/FluentSQLiteDriver/SQLiteConverterDelegate.swift 100.00% <100.00%> (ø)
...rces/FluentSQLiteDriver/SQLiteError+Database.swift 95.23% <100.00%> (+11.90%) ⬆️
...ources/FluentSQLiteDriver/FluentSQLiteDriver.swift 72.72% <72.72%> (+6.06%) ⬆️
...ources/FluentSQLiteDriver/SQLiteRow+Database.swift 63.63% <57.89%> (-29.70%) ⬇️
...FluentSQLiteDriver/FluentSQLiteConfiguration.swift 77.77% <65.51%> (-22.23%) ⬇️
...rces/FluentSQLiteDriver/FluentSQLiteDatabase.swift 86.36% <85.54%> (+2.01%) ⬆️

@gwynne gwynne merged commit be7051a into main May 15, 2024
10 checks passed
@gwynne gwynne deleted the updates branch May 15, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants