Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut down the driver's connection pool safely #94

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 24, 2024

These changes are now available in 4.7.2

Specifically, don't use the soft-deprecated AsyncKit API that calls EventLoopFuture.wait() internally; use the one that at least does it with Dispatch (best we can do without changing Fluent's driver interface).

@gwynne gwynne added the semver-patch Internal changes only label May 24, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy May 24, 2024 09:58
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (9e924b3) to head (91f6ee0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files           7        7           
  Lines         210      210           
=======================================
  Hits          173      173           
  Misses         37       37           
Files Coverage Δ
...ources/FluentSQLiteDriver/FluentSQLiteDriver.swift 72.72% <100.00%> (ø)

@gwynne gwynne merged commit 2362c28 into main May 24, 2024
8 checks passed
@gwynne gwynne deleted the avoid-calling-elf-wait branch May 24, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants