Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override SQLDataType.blob to BYTEA for SQLKit users #264

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 2, 2024

These changes are now available in 2.13.3

Fluent already does this for users of FluentPostgresDriver, this just adds the same behavior to the equivalent data type at the SQLKit layer.

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels May 2, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM, dannflor and ptoffy May 2, 2024 08:16
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.20%. Comparing base (9535dc5) to head (eef600a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   41.18%   41.20%   +0.02%     
==========================================
  Files          13       13              
  Lines         845      847       +2     
==========================================
+ Hits          348      349       +1     
- Misses        497      498       +1     
Files Coverage Δ
Sources/PostgresKit/PostgresDialect.swift 78.26% <50.00%> (-0.85%) ⬇️

@ptoffy
Copy link
Member

ptoffy commented May 2, 2024

Actually why is this crashing on the nightlies?

@gwynne gwynne merged commit ad8ae1e into main May 2, 2024
15 of 18 checks passed
@gwynne gwynne deleted the blob-postgres branch May 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants