Enforced use of JavaScript strict mode

This allows the use of more advanced JavaScript features as well as
potentially catching bugs earlier. There are probably some rough edges
after this transition, so expect more commits fixing those problems.

battle/battle.html

@@ -87,9 +87,11 @@
 		<ul id="team" class="zebra"></ul>
 		<ul id="users"></ul>
 		<script>
-		Battle = null;
+		"use strict";
 
-		Interface = {
+		let Battle = null;
+
+		const Interface = {
 			random : new srandom(172),
 			initialise : function () {
 				document.querySelector("#connect").addEventListener("mousedown", function (event) {

battle/imports.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var paths = [
 	"scripts/functions/objects.js",
 	"scripts/functions/random.js",

battle/scripts/data/Abilities.js

@@ -1,4 +1,6 @@
-Abilities = {
+"use strict";
+
+const Abilities = {
 	"Intimidate" : {
 		effects : [
 			{

battle/scripts/data/Classes.js

@@ -1,4 +1,6 @@
-Classes = {
+"use strict";
+
+const Classes = {
 	"Ace Trainer" : {
 		"payout" : 100
 	},

battle/scripts/data/Clauses.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Clauses = {
 	"Baton Pass" : {
 		description : "Only one Pokémon in each party may know Baton Pass.",

battle/scripts/data/Events.js

@@ -1,2 +1,4 @@
-Events = [
+"use strict";
+
+const Events = [
 ];

battle/scripts/data/Items.js

@@ -1,4 +1,6 @@
-Items = {
+"use strict";
+
+const Items = {
 	"Medicines" : {
 		standard : {
 			use : "healing",

battle/scripts/data/Moves.js

@@ -1,4 +1,6 @@
-Moves = {
+"use strict";
+
+const Moves = {
 	Confused : {
 		type : "Typeless",
 		category : Move.category.physical,

battle/scripts/data/Pokedex.js

@@ -1,4 +1,6 @@
-Pokedex = {
+"use strict";
+
+const Pokedex = {
 	"Missingno. (Nintendo)" : {
 		"types" : ["Bird", "Normal"],
 		"experience" : "fast",

battle/scripts/data/accessories.js

@@ -1,4 +1,6 @@
-Badges = {
+"use strict";
+
+const Badges = {
 	"Boulder" : {
 		enabled : [HMs.indexOf(Moves.Flash)],
 		obediance : null
@@ -10,6 +12,6 @@ Badges = {
 };
 _method(Badges);
 
-Ribbons = {
+const Ribbons = {
 };
 _method(Ribbons);

battle/scripts/data/constants.js

@@ -1,14 +1,16 @@
+"use strict";
+
 var q;
 
-Stats = {
+const Stats = {
 	permanent : ["health", "attack", "defence", "special attack", "special defence", "speed"],
 	transient : ["accuracy", "evasion", "critical"],
 };
 Stats.all = [].concat(Stats.permanent, Stats.transient);
 
-Experiences = ["erratic", "fast", "medium fast", "medium slow", "slow", "fluctuating"];
+const Experiences = ["erratic", "fast", "medium fast", "medium slow", "slow", "fluctuating"];
 
-Evolution = {
+const Evolution = {
 	// Ways to trigger an evolution
 	methods : [
 		"level", // Triggered when the Pokémon levels up (often used in conjunction with other properties)
@@ -23,7 +25,7 @@ Evolution = {
 	]
 };
 
-Natures = {
+const Natures = {
 	"Hardy" : {
 	},
 	"Docile" : {
@@ -116,11 +118,11 @@ Natures = {
 	}
 };
 
-Weathers = ["clear skies", "intense sunlight", "extremely harsh sunlight", "rain", "heavy rain", "sandstorm", "hail", "diamond dust", "shadowy aura", "fog", "strong winds"];
+const Weathers = ["clear skies", "intense sunlight", "extremely harsh sunlight", "rain", "heavy rain", "sandstorm", "hail", "diamond dust", "shadowy aura", "fog", "strong winds"];
 
-Development = ["complete", "incomplete", "unstarted"];
+const Development = ["complete", "incomplete", "unstarted"];
 
-Statuses = ["none", "burned", "frozen", "paralysed", "poisoned", "badly poisoned", "asleep"];
+const Statuses = ["none", "burned", "frozen", "paralysed", "poisoned", "badly poisoned", "asleep"];
 Statuses.Volatile = ["confused", "infatuated"];
 
 /*
@@ -130,7 +132,7 @@ Statuses.Volatile = ["confused", "infatuated"];
 		data:
 			oneself : Whether the Pokémon that triggered the event is itself
 */
-Triggers = {
+const Triggers = {
 	/*
 		Triggered when the Pokémon is sent out.
 	*/
@@ -209,9 +211,9 @@ Triggers = {
 	status : ++ q
 };
 
-Genders = ["male", "female", "neuter"];
+const Genders = ["male", "female", "neuter"];
 
-Time = {
+const Time = {
 	framerate : Settings._("framerate"),
 	speed : Settings._("speed"),
 	millisecond : 1,
@@ -221,9 +223,9 @@ Time = {
 };
 Time.refresh = Time.second / Time.framerate;
 
-Nationalities = ["British"];
+const Nationalities = ["British"];
 
-Item = {
+const Item = {
 	use : [
 		"healing", // Restore health
 		"curing", // Cure a status effect
@@ -233,7 +235,7 @@ Item = {
 	]
 };
 
-Battles = {
+const Battles = {
 	style : ["normal", "double", "sky"],
 	side : {
 		// These are empty objects simply so they're unique from one another. They even conserve uniqueness after being transformed to JSON and back, which is rather handy. They do ~not~, however, need to be identified after being transferred by JSON — just distinguished, because getPokemonInPlace does not actually use the `side` parameter — it just checks for it.
@@ -255,15 +257,15 @@ Battles = {
 	}
 };
 
-Trainers = {
+const Trainers = {
 	type : {
 		NPC : q = 0,
 		local : ++ q,
 		online : ++ q
 	}
 };
 
-Directions = {
+const Directions = {
 	up : q = 0,
 	right : ++ q,
 	down : ++ q,
@@ -278,13 +280,13 @@ Scenes.addData({
 	"Forest Trail" : {}
 });
 
-Creators = {
+const Creators = {
 	"Nintendo" : {
 		"games" : ["RSE"]
 	}
 };
 
-Games = {
+const Games = {
 	"RSE" : {
 		"constituents" : ["Ruby", "Sapphire", "Emerald"],
 		"region" : "Hoenn",
@@ -305,18 +307,18 @@ Games = {
 	}
 };
 
-Regions = ["Hoenn", "Kanto"];
+const Regions = ["Hoenn", "Kanto"];
 
-Pokerus = ["uninfected", "infected", "immune"];
+const Pokerus = ["uninfected", "infected", "immune"];
 
-Tiles = ["grass", "long grass", "dark grass", "seaweed"];
+const Tiles = ["grass", "long grass", "dark grass", "seaweed"];
 
-NoPokemon = {};
+const NoPokemon = {};
 
-onlyPokemon = function (poke) {
+const onlyPokemon = function (poke) {
 	return poke !== NoPokemon;
 };
 
-onlyNoPokemon = function (poke) {
+const onlyNoPokemon = function (poke) {
 	return poke === NoPokemon;
 };

battle/scripts/data/machines.js

@@ -1,7 +1,9 @@
-TMs = [
+"use strict";
+
+const TMs = [
 ];
 
-HMs = [
+const HMs = [
 	"Flash",
 	"Cut"
 ];

battle/scripts/functions/File.js

@@ -1,4 +1,6 @@
-File = {
+"use strict";
+
+const File = {
 	loadFileOfType : function (_store, object, loadEvent, dataForFile, directory, filetype, _paths, uponLoad, uponError, _redirectedPaths) {
 		var store = _store;
 		if (!Files.hasOwnProperty(store))
@@ -84,6 +86,6 @@ File = {
 		}
 	}
 };
-Files = {
+const Files = {
 	nonexistent : []
 };

battle/scripts/functions/Font.js

@@ -1,4 +1,6 @@
-Font = {
+"use strict";
+
+const Font = {
 	load : function (size, weight, style, typeface) {
 		size *= window.devicePixelRatio;
 		if (!["px", "pt", "em", "rem"].contains(("" + size).substr(-2)))

battle/scripts/functions/Sound.js

@@ -1,4 +1,6 @@
-Sound = {
+"use strict";
+
+const Sound = {
 	load : function (_paths, uponLoad, uponError, filetype, playImmediately) {
 		var paths = wrapArray(_paths).slice(0), filetype = arguments.length >= 4 && typeof _filetype !== "undefined" ? _filetype : null;
 		if (filetype === null) {

battle/scripts/functions/Sprite.js

@@ -1,4 +1,6 @@
-Sprite = FunctionObject.new({
+"use strict";
+
+const Sprite = FunctionObject.new({
 	canvases : [],
 	load : function (_paths, uponLoad, uponError, _filetype) {
 		var paths = wrapArray(_paths).slice(0), filetype = arguments.length >= 4 && typeof _filetype !== "undefined" ? _filetype : null;

battle/scripts/functions/functions.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function foreach (array, fn) {
 	var deletion = [], i, broke = false;
 	for (i = 0; i < array.length; ++ i) {
@@ -401,15 +403,15 @@ function quantityWord (times) {
 	return numberword(times) + " times";
 }
 
-Vector = function (vector) {
+const Vector = function (vector) {
 	var self = this;
 	if (arguments.length)
 		self.vector = vector;
 	else
 		self.vector = [0, 0];
 };
 
-Matrix = function (matrix) {
+const Matrix = function (matrix) {
 	/*
 		Matrices in <canvas> contexts are represented by:
 		[a c e]

battle/scripts/functions/objects.js

@@ -1,4 +1,6 @@
-DataObject = {
+"use strict";
+
+const DataObject = {
 	new : function () {
 		var object = {
 			data : {},
@@ -46,7 +48,7 @@ DataObject = {
 	}
 };
 
-FunctionObject = {
+const FunctionObject = {
 	objects : [],
 	initialised : false,
 	new : function (object, details) {

battle/scripts/functions/random.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function srandom (seed) {
 	var self = this;
 

battle/scripts/objects/general/BattleContext.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function BattleContext (client) {
 	if (arguments.length < 1)
 		client = false;
@@ -666,7 +668,6 @@ function BattleContext (client) {
 		},
 		beginOnline : function (seed, alliedTrainers, opposingTrainers, settings, callback) {
 			battleContext.random.seed = seed;
-			settings.flags.pushIfNotAlreadyContained("competitive");
 			battleContext.initiate(alliedTrainers, opposingTrainers, settings, callback);
 		},
 		beginWildBattle : function (alliedTrainers, pokes, settings, callback) {

battle/scripts/objects/general/bag.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function bag (items) {
 	var self = this;
 

battle/scripts/objects/general/battler.js

@@ -1,3 +1,5 @@
+"use strict";
+
 battler.resetDisplay = function (self) {
 	self.display = {
 		transition : 1,

battle/scripts/objects/general/dex.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function dex (data) {
 	var self = this;
 

battle/scripts/objects/general/party.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function party (initial) {
 	var self = this;
 

battle/scripts/objects/general/pokemon.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function pokemon (data, validate) {
 	var self = this;
 

battle/scripts/objects/general/storage.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function storage (initial) {
 	var self = this;
 

battle/scripts/objects/general/trainer.js

@@ -1,3 +1,5 @@
+"use strict";
+
 function trainer (data) {
 	var self = this;