Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated io/ioutil #48

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

anoop142
Copy link
Contributor

@anoop142 anoop142 commented Nov 6, 2023

  • ioutil is deprecated since go 1.16
  • go version in go.mod is 1.16, so removing won't affect us

* ioutil is deprecated since go 1.16
* go version in go.mod is 1.16, so removing won't affect us
@subins2000 subins2000 merged commit d97dcac into varnamproject:master Nov 9, 2023
1 check failed
Copy link
Member

@subins2000 subins2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoop142 Please see the build failures that happened after this change: https://github.com/varnamproject/govarnam/actions/runs/6814023334/job/18529920081

@@ -377,7 +376,7 @@ func TestMLExportAndImport(t *testing.T) {
varnam.Export(exportFileIntendedPath, 300)

// read the whole file at once
b, err := ioutil.ReadFile(exportFilePath)
b, err := os.ReadFile(exportFilePath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file misses the import of "os"

@@ -1,7 +1,6 @@
package govarnamgo

import (
"io/ioutil"
"log"
"os"
"os/exec"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants