Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit tests 🧪 for VST Maker #49

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Add Unit tests 🧪 for VST Maker #49

merged 4 commits into from
Nov 9, 2023

Conversation

anoopmsivadas
Copy link
Member

Copy link
Member

@subins2000 subins2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoopmsivadas One suggestion, everything else LGTM

@@ -75,6 +75,7 @@ func (varnam *Varnam) InitVST(vstPath string) error {

varnam.vstConn.Exec("PRAGMA TEMP_STORE=2;")
varnam.vstConn.Exec("PRAGMA LOCKING_MODE=EXCLUSIVE;")
// varnam.vstConn.Exec("PRAGMA journal_mode=WAL;") // enabled write-ahead logging to avoid db lock issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! will do

@subins2000 subins2000 merged commit 648da8a into varnamproject:master Nov 9, 2023
@anoopmsivadas anoopmsivadas deleted the issue-29 branch November 9, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make unit tests for VST maker
2 participants