Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] multidetector xrf fits #711

Draft
wants to merge 74 commits into
base: master
Choose a base branch
from

Conversation

woutdenolf
Copy link
Collaborator

No description provided.

@woutdenolf woutdenolf force-pushed the xrffit_multidetector branch 4 times, most recently from d330dc2 to 7408ccd Compare August 19, 2020 14:45
@woutdenolf woutdenolf changed the title multidetector xrf fits [WIP] multidetector xrf fits Aug 19, 2020
@vasole
Copy link
Owner

vasole commented Jan 21, 2021

I think it would be much less intrusive to do the following:

  • ClassMcaTheory.py becomes LegacyClassMcaTheory
  • The new ClassMcaTheory imports McaTheory from LegacyClassMcaTheory
  • The new Class (if any) in ClassMcaTheory is named ClassMcaTheory as it is the style followed everywhere else in the project.

@woutdenolf
Copy link
Collaborator Author

ClassMcaTheory.py becomes LegacyClassMcaTheory.py

That's already the case.

The new Class (if any) in ClassMcaTheory is named ClassMcaTheory

Yes that will be the case.

The new ClassMcaTheory imports McaTheory from LegacyClassMcaTheory

That's not going to be possible imo.

@vasole
Copy link
Owner

vasole commented Jan 21, 2021

You are correct. At a certain point I put a dummy ClassMcaTheory to follow the convention available everywhere else :(

@vasole
Copy link
Owner

vasole commented Jan 21, 2021

We'll have to take care.

There are recipes around showing how to directly use the current McaTheory "public" API (configure, setData, estimate, startfit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants