perf: the request client upload function supports more parameters

vbenjs · Sep 19, 2024 · 132de61 · 132de61
1 parent 161820d
commit 132de61
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/packages/effects/request/src/request-client/modules/uploader.test.ts b/packages/effects/request/src/request-client/modules/uploader.test.ts
@@ -34,7 +34,7 @@ describe('fileUploader', () => {
  mockAxiosInstance.post as unknown as ReturnType<typeof vi.fn>
  ).mockResolvedValueOnce(mockResponse);
 
- const result = await fileUploader.upload(url, file);
+ const result = await fileUploader.upload(url, { file });
  expect(result).toEqual(mockResponse);
  expect(mockAxiosInstance.post).toHaveBeenCalledWith(
  url,
@@ -66,7 +66,7 @@ describe('fileUploader', () => {
  headers: { 'Custom-Header': 'value' },
  };
 
- const result = await fileUploader.upload(url, file, customConfig);
+ const result = await fileUploader.upload(url, { file }, customConfig);
  expect(result).toEqual(mockResponse);
  expect(mockAxiosInstance.post).toHaveBeenCalledWith(
  url,
@@ -87,7 +87,7 @@ describe('fileUploader', () => {
  mockAxiosInstance.post as unknown as ReturnType<typeof vi.fn>
  ).mockRejectedValueOnce(new Error('Network Error'));
 
- await expect(fileUploader.upload(url, file)).rejects.toThrow(
+ await expect(fileUploader.upload(url, { file })).rejects.toThrow(
  'Network Error',
  );
  });
@@ -99,7 +99,7 @@ describe('fileUploader', () => {
  mockAxiosInstance.post as unknown as ReturnType<typeof vi.fn>
  ).mockRejectedValueOnce(new Error('Request failed with status code 404'));
 
- await expect(fileUploader.upload(url, file)).rejects.toThrow(
+ await expect(fileUploader.upload(url, { file })).rejects.toThrow(
  'Request failed with status code 404',
  );
  });
@@ -111,7 +111,7 @@ describe('fileUploader', () => {
  mockAxiosInstance.post as unknown as ReturnType<typeof vi.fn>
  ).mockRejectedValueOnce(new Error('Request failed with status code 404'));
 
- await expect(fileUploader.upload(url, file)).rejects.toThrow(
+ await expect(fileUploader.upload(url, { file })).rejects.toThrow(
  'Request failed with status code 404',
  );
  });

diff --git a/packages/effects/request/src/request-client/modules/uploader.ts b/packages/effects/request/src/request-client/modules/uploader.ts
@@ -11,11 +11,14 @@ class FileUploader {
 
  public async upload(
  url: string,
- file: Blob | File,
+ data: { file: Blob | File } & Record<string, any>,
  config?: AxiosRequestConfig,
  ): Promise<AxiosResponse> {
  const formData = new FormData();
- formData.append('file', file);
+
+ Object.entries(data).forEach(([key, value]) => {
+ formData.append(key, value);
+ });
 
  const finalConfig: AxiosRequestConfig = {
  ...config,

diff --git a/packages/effects/request/src/request-client/request-client.test.ts b/packages/effects/request/src/request-client/request-client.test.ts
@@ -79,7 +79,9 @@ describe('requestClient', () => {
  : [400, { error: 'Bad Request' }];
  });
 
- const response = await requestClient.upload('/test/upload', fileData);
+ const response = await requestClient.upload('/test/upload', {
+ file: fileData,
+ });
  expect(response.data).toEqual({ data: 'file uploaded' });
  });