perf: improved exception handling when request status code is 200 (#4679

)
vbenjs · Oct 18, 2024 · 240f0b5 · 240f0b5
1 parent 6f3d509
commit 240f0b5
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 12 deletions.
diff --git a/apps/web-antd/src/api/request.ts b/apps/web-antd/src/api/request.ts
@@ -74,11 +74,13 @@ function createRequestClient(baseURL: string) {
     fulfilled: (response) => {
       const { data: responseData, status } = response;
 
-      const { code, data, message: msg } = responseData;
+      const { code, data } = responseData;
       if (status >= 200 && status < 400 && code === 0) {
         return data;
       }
-      throw new Error(`Error ${status}: ${msg}`);
+
+      const error = { response };
+      throw error;
     },
   });
 

diff --git a/apps/web-ele/src/api/request.ts b/apps/web-ele/src/api/request.ts
@@ -74,11 +74,12 @@ function createRequestClient(baseURL: string) {
     fulfilled: (response) => {
       const { data: responseData, status } = response;
 
-      const { code, data, message: msg } = responseData;
+      const { code, data } = responseData;
       if (status >= 200 && status < 400 && code === 0) {
         return data;
       }
-      throw new Error(`Error ${status}: ${msg}`);
+      const error = { response };
+      throw error;
     },
   });
 

diff --git a/apps/web-naive/src/api/request.ts b/apps/web-naive/src/api/request.ts
@@ -73,11 +73,12 @@ function createRequestClient(baseURL: string) {
     fulfilled: (response) => {
       const { data: responseData, status } = response;
 
-      const { code, data, message: msg } = responseData;
+      const { code, data } = responseData;
       if (status >= 200 && status < 400 && code === 0) {
         return data;
       }
-      throw new Error(`Error ${status}: ${msg}`);
+      const error = { response };
+      throw error;
     },
   });
 

diff --git a/docs/src/en/guide/essentials/server.md b/docs/src/en/guide/essentials/server.md
@@ -233,12 +233,13 @@ function createRequestClient(baseURL: string) {
     fulfilled: (response) => {
       const { data: responseData, status } = response;
 
-      const { code, data, message: msg } = responseData;
+      const { code, data } = responseData;
 
       if (status >= 200 && status < 400 && code === 0) {
         return data;
       }
-      throw new Error(`Error ${status}: ${msg}`);
+      const error = { response };
+      throw error;
     },
   });
 

diff --git a/docs/src/guide/essentials/server.md b/docs/src/guide/essentials/server.md
@@ -236,12 +236,13 @@ function createRequestClient(baseURL: string) {
     fulfilled: (response) => {
       const { data: responseData, status } = response;
 
-      const { code, data, message: msg } = responseData;
+      const { code, data } = responseData;
 
       if (status >= 200 && status < 400 && code === 0) {
         return data;
       }
-      throw new Error(`Error ${status}: ${msg}`);
+      const error = { response };
+      throw error;
     },
   });
 

diff --git a/playground/src/api/request.ts b/playground/src/api/request.ts
@@ -74,12 +74,13 @@ function createRequestClient(baseURL: string) {
     fulfilled: (response) => {
       const { data: responseData, status } = response;
 
-      const { code, data, message: msg } = responseData;
+      const { code, data } = responseData;
 
       if (status >= 200 && status < 400 && code === 0) {
         return data;
       }
-      throw new Error(`Error ${status}: ${msg}`);
+      const error = { response };
+      throw error;
     },
   });