fix: the onOpenChange event for the modal component does not work as …

…expected (#4425)
vbenjs · Sep 18, 2024 · 834cb4c · 834cb4c
1 parent 2c22825
commit 834cb4c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/internal/vite-config/src/config/application.ts b/internal/vite-config/src/config/application.ts
@@ -112,6 +112,7 @@ function createCssOptions(injectGlobalScss = true) {
  }
  return content;
  },
+ api: 'modern-compiler',
  },
  }
  : {},

diff --git a/packages/@core/ui-kit/popup-ui/src/drawer/use-drawer.ts b/packages/@core/ui-kit/popup-ui/src/drawer/use-drawer.ts
@@ -54,10 +54,10 @@ export function useVbenDrawer<
  ...options,
  } as DrawerApiOptions;
 
- // mergedOptions.onOpenChange = (isOpen: boolean) => {
- //  options.onOpenChange?.(isOpen);
- //  injectData.options?.onOpenChange?.(isOpen);
- // };
+ mergedOptions.onOpenChange = (isOpen: boolean) => {
+ options.onOpenChange?.(isOpen);
+ injectData.options?.onOpenChange?.(isOpen);
+ };
  const api = new DrawerApi(mergedOptions);
 
  const extendedApi: ExtendedDrawerApi = api as never;

diff --git a/packages/@core/ui-kit/popup-ui/src/modal/use-modal.ts b/packages/@core/ui-kit/popup-ui/src/modal/use-modal.ts
@@ -58,10 +58,10 @@ export function useVbenModal<TParentModalProps extends ModalProps = ModalProps>(
  ...options,
  } as ModalApiOptions;
 
- // mergedOptions.onOpenChange = (isOpen: boolean) => {
- //  options.onOpenChange?.(isOpen);
- //  injectData.options?.onOpenChange?.(isOpen);
- // };
+ mergedOptions.onOpenChange = (isOpen: boolean) => {
+ options.onOpenChange?.(isOpen);
+ injectData.options?.onOpenChange?.(isOpen);
+ };
  const api = new ModalApi(mergedOptions);
 
  const extendedApi: ExtendedModalApi = api as never;