fix: text overflow when text omission component width is lower than maxWidth

[WitMiao]

Description

before

after

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Improved text display behavior in the ellipsis text component, enhancing readability when expanding or collapsing text.

• Bug Fixes

  • Adjusted class binding for better layout control, ensuring text occupies the intended space in relation to surrounding elements.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 917bff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes involve a modification to the class binding logic in the handleExpand function of the ellipsis-text.vue component. The class for when the line variable equals 1 has been updated from 'inline-block truncate' to 'block truncate', impacting the text display behavior during expansion and collapse.

Changes

Files	Change Summary
packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue	Updated class binding from 'inline-block truncate' to 'block truncate' in the handleExpand function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EllipsisText
    User->>EllipsisText: Click to expand/collapse
    EllipsisText->>EllipsisText: Handle expand/collapse
    EllipsisText->>EllipsisText: Update class binding
    EllipsisText->>User: Render updated text display

Loading

Poem

🐇 In the land of code, where changes bloom,
A tweak to text, dispelling gloom.
From inline to block, it takes its stand,
A clearer view, oh, how it's grand!
With every click, the text will flow,
A joyful leap, watch it grow! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66c732f and 917bff0.

Files selected for processing (1)

• packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue (1 hunks)

Additional comments not posted (1)

packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue (1)

119-119: LGTM! The change fixes the text overflow issue.

The modification in the class binding logic within the handleExpand function, specifically changing the class condition for when the line variable equals 1 from 'inline-block truncate' to 'block truncate', addresses the text overflow issue when the component's width is less than the specified maximum width (maxWidth).

Changing the CSS display property from inline-block to block ensures that the text is properly truncated without overflow when the width is below the maxWidth. This change aligns with the PR objectives and the provided visual comparisons demonstrating the issue before and after the fix.

It's important to note that this adjustment may impact how the text is rendered in relation to surrounding elements, particularly in scenarios where the text is expected to occupy a full line versus being inline with other content. However, given the context of the text truncation component and the specific issue being addressed, the change appears to be appropriate and effective in resolving the overflow problem.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.