Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm catalog #4437

Merged
merged 3 commits into from
Sep 19, 2024
Merged

chore: use pnpm catalog #4437

merged 3 commits into from
Sep 19, 2024

Conversation

anncwb
Copy link
Collaborator

@anncwb anncwb commented Sep 19, 2024

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features

    • Transitioned to a centralized dependency management approach using a catalog reference for various packages.
  • Bug Fixes

    • Improved dependency resolution and management across all modules.
  • Documentation

    • Updated the pnpm-workspace.yaml file to include a comprehensive catalog section for better clarity on dependencies.
  • Chores

    • Standardized version specifications across multiple package.json files to use "catalog:" instead of specific version numbers.

@anncwb anncwb added the feature label Sep 19, 2024
@anncwb anncwb requested review from vince292007 and a team as code owners September 19, 2024 13:30
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: b08bd56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Warning

Rate limit exceeded

@anncwb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 51 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between f257839 and b08bd56.

Walkthrough

The changes involve updating multiple package.json files across various applications and packages to replace specific version numbers of dependencies with a uniform catalog: reference. This transition indicates a centralized approach to dependency management, affecting both dependencies and devDependencies. The modifications span numerous libraries, suggesting a shift towards a more flexible and manageable system for handling package versions.

Changes

File(s) Change Summary
apps/backend-mock/package.json Updated dependencies: jsonwebtoken, nitropack, @types/jsonwebtoken, h3 to use catalog:
apps/web-antd/package.json Updated dependencies: @vueuse/core, ant-design-vue, dayjs, pinia, vue, vue-router to use catalog:
apps/web-ele/package.json Updated dependencies: @vueuse/core, dayjs, element-plus, pinia, vue, vue-router, unplugin-element-plus to use catalog:
apps/web-naive/package.json Updated dependencies: @vueuse/core, naive-ui, pinia, vue, vue-router to use catalog:
docs/package.json Updated dependencies: lucide-vue-next, medium-zoom, radix-vue, vitepress-plugin-group-icons, @nolebase/vitepress-plugin-git-changelog, @vite-pwa/vitepress, vitepress, vue to use catalog:
internal/lint-configs/*/package.json Updated various dependencies in commitlint-config, eslint-config, prettier-config, stylelint-config to use catalog:
internal/node-utils/package.json Updated dependencies: @changesets/git, chalk, consola, dayjs, execa, find-up, nanoid, ora, pkg-types, prettier, rimraf, and devDependency @types/chalk to use catalog:
internal/tailwind-config/package.json Updated all dependencies to use catalog:
internal/tsconfig/package.json Updated vite dependency to use catalog:
internal/vite-config/package.json Updated all dependencies to use catalog:
package.json Updated development dependencies to use catalog:
packages/@core/*/package.json Updated various dependencies across multiple packages to use catalog:
packages/effects/*/package.json Updated dependencies in access, common-ui, hooks, layouts, plugins, request to use catalog:
packages/locales/package.json Updated dependencies: @intlify/core-base, vue, vue-i18n to use catalog:
packages/stores/package.json Updated dependencies: pinia, pinia-plugin-persistedstate, vue, vue-router to use catalog:
packages/types/package.json Updated dependencies: vue, vue-router to use catalog:
packages/utils/package.json Updated vue-router dependency to use catalog:
playground/package.json Updated dependencies: @tanstack/vue-query, @vueuse/core, ant-design-vue, dayjs, pinia, vue, vue-router to use catalog:
pnpm-workspace.yaml Added a new catalog section with various dependencies and their versions
scripts/turbo-run/package.json Updated dependencies: @clack/prompts, cac to use catalog:
scripts/vsh/package.json Updated dependencies: cac, circular-dependency-scanner, depcheck, publint to use catalog:

Possibly related PRs

  • fix: Improve the problem of inaccurate captcha accuracy #4401: The changes in this PR involve updating the package.json files to use a catalog: reference for dependencies, which aligns with the main PR's focus on modifying dependency management in package.json. Both PRs reflect a shift towards a centralized approach for managing package versions.

Suggested reviewers

  • vince292007
  • anncwb
  • Squall2017

🐇 In the garden where bunnies play,
Dependencies changed in a bright new way.
From versions fixed to a catalog's grace,
A hop towards ease in this coding space!
With each little change, we cheer and we sway,
For a smoother tomorrow, hip-hip-hooray! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anncwb anncwb changed the title feat: use pnpm catalog chore: use pnpm catalog Sep 19, 2024
@anncwb anncwb added enhancement New feature or request and removed feature labels Sep 19, 2024
@anncwb anncwb merged commit 56bdb8f into main Sep 19, 2024
13 checks passed
@anncwb anncwb deleted the feature/0919 branch September 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant