fix: improve input browser backfilling style

[anncwb]

Description

fixed #4492

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Style
  • Commented out styles for autofilled input fields, resulting in a more standard appearance without specific browser autofill effects.

[changeset-bot]

⚠️ No Changeset found

Latest commit: cb9a942

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request modifies the global.css file by commenting out a block of styles that applied to the input:-webkit-autofill pseudo-class. This change effectively disables the specific visual styles for autofilled input fields without deleting the code. The update aims to address a visual bug related to the appearance of autofilled inputs in Chrome.

Changes

File Path	Change Summary
packages/@core/base/design/src/css/global.css	Commented out styles for input:-webkit-autofill, disabling autofill styles.

Assessment against linked issues

Objective	Addressed	Explanation
Fix autofill input display issue in Chrome (Issue #4492)	✅

Possibly related PRs

• fix: hover border style same as antd style when validate error #4409: Modifies form-field.vue to enhance visual feedback for invalid form fields, related to input styles.
• fix: the focus style and antd of the input box validation failure should be consistent #4446: Updates form-field.vue for consistent focus styles on input boxes failing validation.
• fix: form verification style fails in pop-up window #4452: Addresses styling for validation errors in Ant Design components, relevant to input style changes.
• fix: some antd components failed to verify styles #4458: Fixes border styles for Ant Design components during validation failures, connected to input field styles.

Suggested reviewers

• vince292007

Poem

🐇 In the meadow where bunnies play,
A CSS change brightens the day.
Autofill's quirks, now tucked away,
Inputs will shine, come what may!
With borders restored, all is okay! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/@core/base/design/src/css/global.css (1)

85-89: Approved: Commenting out custom autofill styles addresses the issue.

This change effectively removes the custom styling for autofilled inputs, which should resolve the issue of abnormal display in Chrome's memory mode. By allowing the browser's default autofill styling, the input fields should now retain their borders and overall design when autofilled.

Consider the following improvements:

1. Instead of completely removing the styles, you might want to adjust them to match your design while still allowing the autofill to be visible. For example:

input:-webkit-autofill {
  -webkit-text-fill-color: inherit;
  -webkit-box-shadow: 0 0 0px 1000px transparent inset;
  transition: background-color 5000s ease-in-out 0s;
}

2. To ensure consistency across different browsers, you may want to add similar rules for other vendor prefixes:

input:-webkit-autofill,
input:-moz-autofill,
input:-ms-autofill {
  /* Your styles here */
}

3. Consider adding specific styles for the autofill background and text color to match your design system:

input:-webkit-autofill {
  -webkit-text-fill-color: theme('colors.input.text');
  -webkit-box-shadow: 0 0 0px 1000px theme('colors.input.background') inset;
}

These suggestions can help maintain a consistent look while still addressing the original issue.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a72b8ac and cb9a942.

📒 Files selected for processing (1)

• packages/@core/base/design/src/css/global.css (1 hunks)