Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 #4580

Closed
wants to merge 3 commits into from
Closed

1 #4580

wants to merge 3 commits into from

Conversation

1571312541
Copy link

@1571312541 1571312541 commented Oct 6, 2024

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Release Notes

  • New Features

    • Added a new script for a dedicated development environment for the @vben/web-demo package.
  • Changes

    • Updated directory references from @core to _core across various documentation and configuration files.
    • Removed Baidu tracking scripts from multiple HTML files, indicating a shift in analytics strategy.
  • Bug Fixes

    • Adjusted ESLint configurations to reflect updated directory paths.

These changes enhance project organization and streamline the development process.

@1571312541 1571312541 requested review from anncwb, vince292007 and a team as code owners October 6, 2024 10:55
Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: 1b87f1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Oct 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes several changes primarily focused on updating directory references from /packages/@core/ to /packages/_core/ across various files, including the .github/CODEOWNERS and multiple documentation files. Additionally, several Visual Studio Code configuration files were deleted, which included settings for extensions, snippets, and launch configurations. The changes also introduce a new script in package.json for a demo development environment and modify the ESLint configuration to reflect the new directory structure.

Changes

File Path Change Summary
.github/CODEOWNERS Updated directory ownership from /packages/@core/ to /packages/_core/.
.vscode/extensions.json Removed configuration file for recommended and unwanted VS Code extensions.
.vscode/global.code-snippets Removed file containing reusable code snippets for JavaScript, TypeScript, and Vue.
.vscode/launch.json Removed file with configurations for Chrome debugging sessions.
.vscode/settings.json Removed comprehensive configuration settings for Visual Studio Code.
apps/web-antd/index.html Removed Baidu tracking script injection from HTML file.
apps/web-ele/index.html Removed Baidu tracking script injection from HTML file.
apps/web-naive/index.html Removed Baidu tracking script injection from HTML file.
docs/src/en/guide/other/project-update.md Updated directory name from packages/@core to packages/_core.
docs/src/en/guide/project/dir.md Changed directory name from @core to _core in documentation.
docs/src/guide/other/project-update.md Updated directory name from packages/@core to packages/_core.
docs/src/guide/project/dir.md Changed directory name from @core to _core in documentation.
internal/lint-configs/eslint-config/src/custom-config.ts Updated ESLint configuration to reflect new directory structure.
internal/vite-config/src/plugins/index.ts Modified loadCommonPlugins function to include options for viteVueDevTools.
package.json Added new script "dev:demo" for the @vben/web-demo package.
packages/_core/composables/package.json Updated directory field in repository object from packages/@core/composables to packages/_core/composables.
packages/_core/preferences/package.json Updated directory field in repository object from packages/@core/preferences to packages/_core/preferences.

Possibly related PRs

🐰 In the garden of code we hop,
Changing paths from core to top.
With snippets gone and scripts anew,
Our project blooms, fresh as the dew.
So let’s celebrate this change so bright,
With binkies and joy, we code through the night! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@1571312541 1571312541 closed this Oct 6, 2024
@1571312541
Copy link
Author

手残提交的,可删除

@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant