Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sagemathgh-37630: Enhance documentation of Drinfeld module Potemine j…
…-invariants <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The definition of $j$-invariants, *basic* $j$-invariants and $j_k$-invariants defer in [Potemine's article](https://link.springer.com/article/10.1023/A:1009724323513) and [Papikian's book](https://link.springer.com/book/10.1007/978-3-031-19707-9). Thanks to @DavidAyotte, we follow Potemine's convention. Seeing however the growing popularity of Papikian's book, I reckon it is a good idea to add a note in the documentation addressing those differences. Also, I fixed a typo. ### Potemine: ![image](https://github.com/sagemath/sage/assets/31312212/5e09f13c-782d- 4665-b5a6-c0c8947cb74f) ![image](https://github.com/sagemath/sage/assets/31312212/65c6e812-3f93- 4a4c-9bb7-ce84ca1dcf10) ### Papikian: ![image](https://github.com/sagemath/sage/assets/31312212/eb811d6f-5a3c- 4764-b9f8-d12d562309b3) ![image](https://github.com/sagemath/sage/assets/31312212/d100c393-dd6d- 47b0-b39b-edfd02cda7a6) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37630 Reported by: Antoine Leudière Reviewer(s): David Ayotte
- Loading branch information