Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(releasing): Prepare VRL v0.19.0 #1058

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore(releasing): Prepare VRL v0.19.0 #1058

merged 2 commits into from
Oct 1, 2024

Conversation

pront
Copy link
Member

@pront pront commented Sep 30, 2024

No description provided.

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 30, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise 🚀

CHANGELOG.md Outdated
### Fixes

- The `parse_xml` function now doesn't add an unnecessary `text` key when processing single nodes. (https://github.com/vectordotdev/vrl/pull/849)
- Adds support for hyphens in the JIT path parser (https://github.com/vectordotdev/vrl/pull/1025)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure users will understand this one. What is the user-facing change?

Copy link
Member Author

@pront pront Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This essentially means that paths with a - e.g. a-b-c can now be dynamically parsed while previously that would result in an error (or it would need quotes).

Example:

Any suggestions here based on the above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, this just affects the grok parser? If so, I would say something like:

`parse_grok` and `parse_groks` no longer require field names containing a hyphen (e.g. `@a-b`) to be quoted.

@pront pront requested a review from jszwedko September 30, 2024 20:24
@pront pront enabled auto-merge October 1, 2024 13:11
@pront pront added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 4ff13f4 Oct 1, 2024
14 checks passed
@pront pront deleted the pront/vrl-0.19.0 branch October 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: releasing no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants