-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(releasing): Prepare VRL v0.19.0 #1058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise 🚀
CHANGELOG.md
Outdated
### Fixes | ||
|
||
- The `parse_xml` function now doesn't add an unnecessary `text` key when processing single nodes. (https://github.com/vectordotdev/vrl/pull/849) | ||
- Adds support for hyphens in the JIT path parser (https://github.com/vectordotdev/vrl/pull/1025) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure users will understand this one. What is the user-facing change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This essentially means that paths with a -
e.g. a-b-c
can now be dynamically parsed while previously that would result in an error (or it would need quotes).
Example:
- valid: https://github.com/vectordotdev/vrl/pull/1025/files#diff-7b54bf8eddc8ffc8e619d38dcc2cd01afc4266b5bc6e3549d1b8e7877a72504e
- invalid: https://github.com/vectordotdev/vrl/pull/1025/files#diff-4f80e68270b3ab44ec169d272d997fb6f483fbdeb892a58419bdbb735fdfcacb
Any suggestions here based on the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, this just affects the grok parser? If so, I would say something like:
`parse_grok` and `parse_groks` no longer require field names containing a hyphen (e.g. `@a-b`) to be quoted.
No description provided.