user can now upload logo from storage #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for adoring-allen-cc4d44 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I tested this and it LGTM, wdyt @vedant-jain03 ? |
|
@Shardul-Kavar good work, could you please attach the working in form of video or GIF! |
vedant-jain03
requested changes
Oct 6, 2022
There was a problem hiding this comment.
LGTM, Great work @Shardul-Kavar
Last thing, could you check this PR compatibility with #19
yeah sure |
I've added Logo to all remaining templates, It's PR compatible as well but where should it's placement be... like directly above "course director"? |
vedant-jain03
requested changes
Oct 8, 2022
There was a problem hiding this comment.
@Shardul-Kavar Good work, I tested it and find out the other templates logo is not aligned, try my suggestion!
Thanks!
| <h1 style={{ fontSize: '3rem', color: 'black',position: 'absolute', top:'9rem',left:'25px',wordBreak:'break-all' }}>{this.props.name === '' ? 'Name' : this.props.name}</h1> | ||
| <h6 style={{ fontSize: '15px', fontWeight: '600', color: '#213a62',width:'60%',position: 'absolute', top:'17rem',left:'27px',wordBreak:'break-all' }}>{this.props.desc === '' ? 'for the active participation in the event and for giving efforts,ideas and Knowledge.' : this.props.desc}</h6> | ||
| <h1 style={{ fontSize: '15px', color: 'black',position: 'absolute', top:'19.95rem',left:'8.6rem',wordBreak:'break-all' }}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1> | ||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} |
There was a problem hiding this comment.
Suggested change
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '4%', left: '93%', transform: 'translate(-50%,0)' }} alt="logo" />} |
| @@ -104,16 +104,16 @@ export class ComponentToPrint extends React.PureComponent { | |||
| <h2 style={{ fontSize: '12px', color: '#781114', textDecoration: 'underline', textTransform: 'uppercase' }}>Course Director</h2> | |||
| <h1 style={{ fontSize: '20px', color: '#0300b0', textTransform: 'uppercase' }}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1> | |||
| </div> | |||
| {this.props.logo === '' ? "" : <img src={this.props.logo} style={{ position: 'absolute', width: '6rem', borderRadius: '50%', top: '20%', left: '35%' }} alt="logo" />} | |||
| {this.props.logo === '' ? "" : <img src={this.props.logo} style={{ position: 'absolute', width: '6rem', borderRadius: '50%', top: '20%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |||
There was a problem hiding this comment.
Suggested change
| {this.props.logo === '' ? "" : <img src={this.props.logo} style={{ position: 'absolute', width: '6rem', borderRadius: '50%', top: '20%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |
| {this.props.logo === '' ? "" : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '25%', left: '40%', transform: 'translate(-50%,0)' }} alt="logo" />} |
| @@ -125,16 +125,16 @@ export class ComponentToPrint extends React.PureComponent { | |||
| <h2 style={{ fontSize: '12px', color: 'white', textDecoration: 'underline' }}>Course Director</h2> | |||
| <h1 style={{ fontSize: '20px', color: '#ffff58', fontWeight: '100'}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1> | |||
| </div> | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />} | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '26%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |||
There was a problem hiding this comment.
Suggested change
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '26%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '3rem', borderRadius: '50%', top: '24%', left: '49%', transform: 'translate(-50%,0)' }} alt="logo" />} |
| @@ -146,16 +146,16 @@ export class ComponentToPrint extends React.PureComponent { | |||
| <h2 style={{ fontSize: '12px', color: 'red', textDecoration: 'underline' }}>Course Director</h2> | |||
| <h1 style={{ fontSize: '20px', color: 'black',}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1> | |||
| </div> | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />} | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '62%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |||
There was a problem hiding this comment.
Suggested change
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '62%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '57%', left: '49%', transform: 'translate(-50%,0)' }} alt="logo" />} |
| @@ -167,16 +167,16 @@ export class ComponentToPrint extends React.PureComponent { | |||
| <h2 style={{ fontSize: '12px', color: '#c929ff', textDecoration: 'underline' }}>Course Director</h2> | |||
| <h1 style={{ fontSize: '20px', color: 'rgb(19, 22, 207)',}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1> | |||
| </div> | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />} | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '62%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |||
There was a problem hiding this comment.
Suggested change
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '62%', left: '50%', transform: 'translate(-50%,0)' }} alt="logo" />} | |
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '57%', left: '49%', transform: 'translate(-50%,0)' }} alt="logo" />} |
| @@ -188,7 +188,7 @@ export class ComponentToPrint extends React.PureComponent { | |||
| <h2 style={{ fontSize: '12px', color: '#0edee6', textDecoration: 'underline' }}>Course Director</h2> | |||
| <h1 style={{ fontSize: '20px', color: 'rgb(6, 124, 214)',}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1> | |||
| </div> | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />} | |||
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '61%', left: '53%', transform: 'translate(-50%,0)' }} alt="logo" />} | |||
There was a problem hiding this comment.
Suggested change
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '61%', left: '53%', transform: 'translate(-50%,0)' }} alt="logo" />} | |
| {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '57%', left: '52%', transform: 'translate(-50%,0)' }} alt="logo" />} |
yashikajotwani12
approved these changes
Oct 23, 2022
|
Hi, @vedant-jain03 I hope this finds you well and I know it's after a long time but can you give me pointers to resolve this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12
https://www.loom.com/share/74d1cbe81ca442839192ef746a7e0b82