Add vips #630
Closed
Add vips #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the name be CrystalVips rather than vips? |
|
@kojix2 ah yes, let's make it consistent please 👍 |
veelenga
reviewed
Dec 13, 2023
| @@ -321,6 +321,7 @@ described in [RFC 8032] | |||
| * [ffmpeg](https://github.com/spider-gazelle/ffmpeg) - FFmpeg bindings that works with StumpyPNG to extract frames | |||
| * [Pluto](https://github.com/phenopolis/pluto) - A fast and convenient image processing library | |||
| * [stumpy_png](https://github.com/stumpycr/stumpy_png) - Read and write PNG images | |||
| * [CrystalVips](https://github.com/naqvis/crystal-vips) - Crystal bindings to [libvips](https://github.com/libvips/libvips) image processing library | |||
There was a problem hiding this comment.
Suggested change
| * [CrystalVips](https://github.com/naqvis/crystal-vips) - Crystal bindings to [libvips](https://github.com/libvips/libvips) image processing library | |
| * [crystal-vips](https://github.com/naqvis/crystal-vips) - Crystal bindings to [libvips](https://github.com/libvips/libvips) image processing library |
There was a problem hiding this comment.
Also, please make sure it follows alphabetical order (in scope of the section)
| @@ -321,6 +321,7 @@ described in [RFC 8032] | |||
| * [ffmpeg](https://github.com/spider-gazelle/ffmpeg) - FFmpeg bindings that works with StumpyPNG to extract frames | |||
| * [Pluto](https://github.com/phenopolis/pluto) - A fast and convenient image processing library | |||
| * [stumpy_png](https://github.com/stumpycr/stumpy_png) - Read and write PNG images | |||
| * [CrystalVips](https://github.com/naqvis/crystal-vips) - Crystal bindings to [libvips](https://github.com/libvips/libvips) image processing library | |||
There was a problem hiding this comment.
If this lib is purely bindings to libvips, it should probably go under the C Bindings section. But if it's bindings + a Crystal API on top of it, probably should update the desc to point that out. E.g. something like:
Image processing library based on libvips
To denote its more than just bindings.
|
@kojix2 please feel free to re-open if you still want to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link
https://github.com/naqvis/crystal-vips
Checklist