Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vega-Lite to 5.20.1, Vega-Embed 6.26, Vega Themes 2.15 #178

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Update Vega-Lite to 5.20.1, Vega-Embed 6.26, Vega Themes 2.15 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vl-convert-python/tests/test_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def load_expected_png(name, vl_version, theme=None):
@pytest.mark.parametrize("name", ["circle_binned", "seattle-weather", "stacked_bar_h"])
@pytest.mark.parametrize(
"vl_version",
["v5_8", "v5_12", "v5_13", "v5_14", "v5_15", "v5_16", "v5_17", "v5_18", "v5_19"],
["v5_8", "v5_13", "v5_14", "v5_15", "v5_16", "v5_17", "v5_18", "v5_19", "v5_20"],
)
@pytest.mark.parametrize("as_dict", [False, True])
def test_vega(name, vl_version, as_dict):
Expand All @@ -96,14 +96,14 @@ def test_vega(name, vl_version, as_dict):
"vl_version",
[
"5.8",
"5.12",
"5.13",
"5.14",
"5.15",
"5.16",
"5.17",
"5.18",
"5.19",
"5.20",
],
)
def test_vegalite_to_html_no_bundle(name, vl_version):
Expand Down Expand Up @@ -132,14 +132,14 @@ def test_vegalite_to_html_no_bundle(name, vl_version):
"vl_version",
[
"5.8",
"5.12",
"5.13",
"5.14",
"5.15",
"5.16",
"5.17",
"5.18",
"5.19",
"5.20",
],
)
def test_vegalite_to_html_bundle(name, vl_version):
Expand Down
31 changes: 15 additions & 16 deletions vl-convert-rs/src/module_loader/import_map.rs
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions vl-convert-rs/tests/test_specs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,14 @@ mod test_vegalite_to_vega {
fn test(
#[values(
VlVersion::v5_8,
VlVersion::v5_12,
VlVersion::v5_13,
VlVersion::v5_14,
VlVersion::v5_15,
VlVersion::v5_16,
VlVersion::v5_17,
VlVersion::v5_18,
VlVersion::v5_19,
VlVersion::v5_20,
)]
vl_version: VlVersion,

Expand Down Expand Up @@ -361,14 +361,14 @@ mod test_vegalite_to_html_no_bundle {
fn test(
#[values(
VlVersion::v5_8,
VlVersion::v5_12,
VlVersion::v5_13,
VlVersion::v5_14,
VlVersion::v5_15,
VlVersion::v5_16,
VlVersion::v5_17,
VlVersion::v5_18,
VlVersion::v5_19,
VlVersion::v5_20,
)]
vl_version: VlVersion,

Expand Down Expand Up @@ -409,14 +409,14 @@ mod test_vegalite_to_html_bundle {
fn test(
#[values(
VlVersion::v5_8,
VlVersion::v5_12,
VlVersion::v5_13,
VlVersion::v5_14,
VlVersion::v5_15,
VlVersion::v5_16,
VlVersion::v5_17,
VlVersion::v5_18,
VlVersion::v5_19,
VlVersion::v5_20,
)]
vl_version: VlVersion,

Expand Down
1 change: 0 additions & 1 deletion vl-convert-rs/tests/vl-specs/expected/v5_12/seattle-weather.vg.json
View file
Open in desktop

This file was deleted.

Loading
Loading