Update Deno, build aarch64 wheels with QEMU #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes: |
|
Building with the standard manylinux docker container with QEMU in 66d5d73 produced a working aarch64 wheel 🎉 . It took 2.5 hours to build a single wheel though. Also, the wheel built with |
jonmmease
changed the title
since they are so slow
|
Compiling with QEMU is a bit slow (2.5 hours to build the wheel), but we only need to run this on releases, so I think it's acceptable going forward. It also unblocked the ability to update Deno, which is a big benefit itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67 by building the aarch64 wheels with QEMU. This also unblocks the ability to update Deno.
I ran into some issues with cross-compiling the CLI executables on osx-arm64 and linux-aarch64, so I went ahead and removed these for now.