-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies based voyager build change #32
base: master
Are you sure you want to change the base?
Fix dependencies based voyager build change #32
Conversation
@@ -0,0 +1,36 @@ | |||
const path = require('path'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajainarayanan I though you say the normal lib build works fine -- do we really still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for font-awesome-sass-loader
Since we marked font-awesome-*
as external in voyager we need to add this. This is to parse font awesome font files and serve them using url-loader
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the webpack build step to generate a library build explicitly for electron environment in the voyager PR. This however is required for using font-awesome loader in voyager.
@ssharif6 @FelixCodes -- can you help test if this is still working well? |
…m canvas node module)
@kanitw Have updated the PR. This PR requires the corresponding PR in vega/voyager-server#4 to be merged before this is merged. I am sorry for the circle of PRs but unless we release a new version of voyager I don't know how we can merge vega/voyager-server#4 and this PR. Do let me know if there is an easier way. Note:Please don't merge this PR yet as the node modules still point to local npm modules. |
@FelixCodes -- you mention you have some comments for this PR the other day. Can you post them so @ajainarayanan can take a look?
Oh you can use |
@kanitw I understand |
Based on vega/voyager#678 and vega/voyager#726
package.json
to include modules marked as external by voyager.font-awesome
andfont-awesome-loader
to be built as dependencies.index.html
to require correct modules based on voyager changes.Note:
voyager
dependency doesn't have the right version yet.