Fix inconsistent field name line edit focus behaviour when creating n…

…ew vector layers (qgis#58538)

* Fix inconsistent behaviour in create new layer dialogues by returning focus to
the field name line edits in the mAddAttributeButton_clicked slot methods of the
new layer dialogues.

Fixes qgis#58482

* Remove Qt::MouseFocusReason argument from setFocus() calls so that the default
Qt::OtherFocusReason is used.

src/app/qgsnewspatialitelayerdialog.cpp

@@ -178,6 +178,11 @@ void QgsNewSpatialiteLayerDialog::mAddAttributeButton_clicked()
     checkOk();
 
     mNameEdit->clear();
+
+    if ( !mNameEdit->hasFocus() )
+    {
+      mNameEdit->setFocus();
+    }
   }
 }
 

src/gui/qgsnewgeopackagelayerdialog.cpp

@@ -237,6 +237,11 @@ void QgsNewGeoPackageLayerDialog::mAddAttributeButton_clicked()
     checkOk();
 
     mFieldNameEdit->clear();
+
+    if ( !mFieldNameEdit->hasFocus() )
+    {
+      mFieldNameEdit->setFocus();
+    }
   }
 }
 

src/gui/qgsnewmemorylayerdialog.cpp

@@ -355,6 +355,11 @@ void QgsNewMemoryLayerDialog::mAddAttributeButton_clicked()
     mAttributeView->addTopLevelItem( new QTreeWidgetItem( QStringList() << fieldName << fieldType << width << precision ) );
 
     mFieldNameEdit->clear();
+
+    if ( !mFieldNameEdit->hasFocus() )
+    {
+      mFieldNameEdit->setFocus();
+    }
   }
 }
 

src/gui/qgsnewvectorlayerdialog.cpp

@@ -215,8 +215,15 @@ void QgsNewVectorLayerDialog::mAddAttributeButton_clicked()
   //use userrole to avoid translated type string
   const QString myType = mTypeBox->currentData( Qt::UserRole ).toString();
   mAttributeView->addTopLevelItem( new QTreeWidgetItem( QStringList() << myName << myType << myWidth << myPrecision ) );
+
   checkOk();
+
   mNameEdit->clear();
+
+  if ( !mNameEdit->hasFocus() )
+  {
+    mNameEdit->setFocus();
+  }
 }
 
 void QgsNewVectorLayerDialog::mRemoveAttributeButton_clicked()